Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on the page scrolls down when entering the page via direct link #1382

Open
ilona-x opened this issue Oct 26, 2022 · 1 comment
Open

Comments

@ilona-x
Copy link

ilona-x commented Oct 26, 2022

At which URL did you encounter the problem?

https://finto.fi/ykl/fi/page/99.16

What steps will reproduce the problem?

Opening a class/concept page via direct link

What is the expected output? What do you see instead?

What is the expected output:

When opening the page you expect to see the top of the page
kuva

What do you see instead?

When the page and the hierarchy tree opens, the focus of the page scrolls down

kuva

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

Firefox, Chrome & Edge

@osma
Copy link
Member

osma commented Oct 26, 2022

This is an unfortunate side effect of the way we reimplemented the custom scrollbar functionality in the latest Skosmos release. When we switched away from the old and unmaintained mCustomScrollbar library, we had to also reimplement the centering of the hierarchy so that the currently selected concept is visible in the hierarchy when you open a concept page. I did that in PR #1372 (and tweaked in #1374) using the standard Element.scrollIntoView method. But this may scroll the entire page when the page is long enough, not just the hierarchy view which was intended.

@osma osma added the bug label Oct 26, 2022
@osma osma added this to the Next Tasks milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants