Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI language menu links don't work in the nav bar #1581

Closed
joelit opened this issue Jan 24, 2024 · 4 comments
Closed

UI language menu links don't work in the nav bar #1581

joelit opened this issue Jan 24, 2024 · 4 comments
Labels
Milestone

Comments

@joelit
Copy link
Contributor

joelit commented Jan 24, 2024

URL address of the page where you encountered the problem

Any Skosmos page!

Description of the problem

  1. Choose a language from the nav bar
  2. Get a Skosmos 'not found' error message
  3. If your page URL was before localhost/Skosmos/something, it is now localhost/Skosmos/Skosmos/something
  4. You can still write the correct URL for the chosen language yourself in the browser, though

Additional information (e.g. screenshots) about the problem

<a class="fs-6 text-light ms-3 text-decoration-none" id="language-{{ langcode}}" href="{{ request.langurl(langcode) }}"> {{ langdata.name }}</a>

@joelit joelit added the bug label Jan 24, 2024
@joelit joelit added this to the 3.0 milestone Jan 24, 2024
@osma
Copy link
Member

osma commented Jan 24, 2024

This affects my local installation at http://localhost/Skosmos/ but not the demo installation at https://test.dev.finto.fi - presumably because the former has /Skosmos in the URL and the latter doesn't.

@osma
Copy link
Member

osma commented Jan 25, 2024

Probably this has to do with setting the base URL.

@joelit joelit moved this to Proposed Skosmos 3.0 issues (to do) in Skosmos 3.0 Backlog Aug 8, 2024
@osma
Copy link
Member

osma commented Jan 28, 2025

@osma note to self: check if this still happens (I think I've fixed it)

@osma
Copy link
Member

osma commented Jan 28, 2025

This was fixes as part of PR #1657. Closing.

@osma osma closed this as completed Jan 28, 2025
@github-project-automation github-project-automation bot moved this from Proposed Skosmos 3.0 issues (to do) to Issue/PR closed in Skosmos 3.0 Backlog Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Issue/PR closed
Development

No branches or pull requests

2 participants