Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit test coverage #415

Closed
osma opened this issue Dec 18, 2015 · 2 comments
Closed

Increase unit test coverage #415

osma opened this issue Dec 18, 2015 · 2 comments
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Dec 18, 2015

Unit test coverage has fallen to 76% in Skosmos 1.4.

We should aim for more.

Looking at the coverage report I see that some private/protected methods, such as GenericSparql->generateConceptSearchQueryInner, are marked as not covered although they must have been visited by the unit test for some public method. I think PHPUnit has an option that tells it to cover protected methods as well even though the @covers annotation is only for a the public method, we should try that.

Of course there are also really missing unit tests, for example concept searches are not well covered in general and apparently JenaTextSparql is not tested at all, even though the GenericSparql tests could be used to test it as well using a slightly different testconfig.inc.

@osma osma modified the milestones: Next Tasks, 1.5 Dec 18, 2015
@henriyli
Copy link
Collaborator

Coverage is now over 90%.

@kinow
Copy link
Collaborator

kinow commented Feb 15, 2016

👍 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants