Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by notation code #456

Closed
osma opened this issue Feb 16, 2016 · 5 comments
Closed

Search by notation code #456

osma opened this issue Feb 16, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@osma
Copy link
Member

osma commented Feb 16, 2016

Entering a notation code in the search box should give the concept with that notation.
E.g. in UDCS summary entering "=18" in the search box should find Albania.

@osma osma added this to the Next Tasks milestone Feb 16, 2016
@osma osma added the size-medium 2 hours to 2 days label Feb 16, 2016
@osma
Copy link
Member Author

osma commented Feb 16, 2016

I think we could use exact literal matching without a text index in the SPARQL query to implement this. This means that notation code lookups will be case sensitive.

@osma osma modified the milestones: Next Tasks, 1.7 Feb 16, 2016
@osma osma self-assigned this May 12, 2016
@osma osma closed this as completed in f3a962d May 12, 2016
@osma
Copy link
Member Author

osma commented May 31, 2016

Doesn't work, searching for =18 in UDCS gives no result

@osma osma reopened this May 31, 2016
@osma
Copy link
Member Author

osma commented May 31, 2016

Also the unit test has a redundant line, there is no method getRawSearchTerm

@henriyli
Copy link
Collaborator

henriyli commented Jun 6, 2016

UDC Summary uses data types in the notations e.g. skos:notation "=..."^^udcs:UDCnotation ; which makes this hard to do efficiently since you'd need a filter for that. Leaving this for a later date.

@osma
Copy link
Member Author

osma commented Jun 6, 2016

Simple case (no datatype) has been implemented, so I'm closing this and opening another issue for the notation with datatype case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants