Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARQL search query is referring to ?match in GROUP BY and ORDER BY, while ?match is not in the SELECT clause #694

Closed
tfrancart opened this issue Jan 29, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@tfrancart
Copy link
Contributor

I can't be 100% sure, but :

At https://github.com/NatLibFi/Skosmos/blob/master/model/sparql/GenericSparql.php#L1015, the GROUP BY clause is grouping on ?match, while ?match is not a variable in the SELECT clause.

At https://github.com/NatLibFi/Skosmos/blob/master/model/sparql/GenericSparql.php#L1016, the ORDER BY clause is ordering on ?match, while ?match is not a variable in the SELECT clause.

@tfrancart tfrancart changed the title SPARQL search query ir referring to ?match in GROUP BY and ORDER BY, while ?match is not in the SELECT clause SPARQL search query is referring to ?match in GROUP BY and ORDER BY, while ?match is not in the SELECT clause Jan 29, 2018
@osma osma added the bug label Mar 12, 2018
@osma osma added this to the 2.0 milestone Mar 12, 2018
@osma
Copy link
Member

osma commented Mar 12, 2018

I think ?match should be coming from the inner query generated by generateConceptSearchQueryInner. But need to verify.

Did you find a solution by yourself?

@osma osma assigned osma and joelit and unassigned joelit Aug 22, 2018
@osma
Copy link
Member

osma commented Aug 22, 2018

?match is set in a BIND statement a dozen or so lines above the GROUP BY and ORDER BY, currently on line 1008: https://github.com/NatLibFi/Skosmos/blob/master/model/sparql/GenericSparql.php#L1008

Closing the issue as there appears to be no problem here.

@osma osma closed this as completed Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants