Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept type not mentioned in enter search results #776

Closed
tpalonen opened this issue Jun 13, 2018 · 10 comments
Closed

Concept type not mentioned in enter search results #776

tpalonen opened this issue Jun 13, 2018 · 10 comments
Assignees
Milestone

Comments

@tpalonen
Copy link

tpalonen commented Jun 13, 2018

Concept type is not mentioned in enter search results. In ontologies where there are several concept types this information would be useful. In domain ontologies which are linked to general ontologies (such as JUHO, which is linked to YSO) this information is crucial. At the moment, enter search does not show whether a given concept is a domain ontology concept or a general ontology concept. This information may be inferred from the concept's URI, but not in all cases. And as far as I know, URI name space isn't exactly meant for indicating concept types.

See also: #546

@kinow
Copy link
Collaborator

kinow commented Jun 13, 2018

Maybe for this and for #546 we could have a separate section like "Advanced Search", and leave the current feature untouched for now.

Advanced search could have specific filters, by Concept Type, Concept, or maybe even custom SPARQL predicate. WDYT @tpalonen ?

@tpalonen
Copy link
Author

tpalonen commented Jun 13, 2018

@kinow the feature you suggest already exists. Enter search results can be narrowed by concept type, parent, group or subvocabulary. This is a heavy-user feature and nice as such. But for non-heavy-users, the concept type should really be shown already in search results. This is crucial for many domain ontologies in finto.fi since they all include general ontology YSO in them.

@kinow
Copy link
Collaborator

kinow commented Jun 13, 2018

@tpalonen ah, I think I got it now. So for example, in this search page

http://finto.fi/koko/en/search?clang=fi&q=aall

each result returned would include the Concept Type?

@tpalonen
Copy link
Author

@kinow precisely. And this search page further explains my point (see the URIs):
http://finto.fi/juho/en/search?clang=fi&q=ilmast&vocabs=

@kinow
Copy link
Collaborator

kinow commented Jun 13, 2018

Noticed the fields on the left sidebar, indeed no necessity of an advanced search screen.

@tpalonen if you have a test instance maybe you can try this one master...kinow:display-concepttype-search

Here's what it looks like

image

And if that looks good we can wait @henriyli or @osma to review it too, and see if that'd be an interesting feature.

Worked on this one because never used much of search, and also wanted to see how to add translated words 🕺 quite simple thanks to the docs! And icon from https://feathericons.com/, with colour changed in Inkscape.

@osma
Copy link
Member

osma commented Aug 21, 2018

Wow, I had missed this thread, looks very good @kinow! We'll see whether this could be incorporated in the upcoming 2.0 release.

@osma osma added this to the 2.0 milestone Aug 21, 2018
@kinow
Copy link
Collaborator

kinow commented Aug 21, 2018

Thanks for reviewing it! I think I didn't create a PR for this one (on mobile now). Should I prepare one??

@osma
Copy link
Member

osma commented Aug 22, 2018

@kinow a PR would be great!

@osma osma modified the milestones: 2.0, Next Tasks Aug 22, 2018
@kinow
Copy link
Collaborator

kinow commented Aug 22, 2018

A fresh PR on its way ! 🎉 #781

@joelit
Copy link
Contributor

joelit commented Dec 12, 2018

I drew a new icon to get around the issue with licencing and attribution. Also updated the tooltips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants