Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed should follow naming of the tns-core-modules files #160

Open
PeterStaev opened this issue Aug 15, 2019 · 1 comment
Open

Seed should follow naming of the tns-core-modules files #160

PeterStaev opened this issue Aug 15, 2019 · 1 comment
Labels

Comments

@PeterStaev
Copy link

PeterStaev commented Aug 15, 2019

Currently the seed uses naming different than the ones that are used through in the tns-core-modules. Using similar names will make it easier for people to also navigate (and possibly contribute) to the main Nativescript repo. So:

  • index.d.ts should become <name-of-plugin>.d.ts
  • <name-of-plugin>.common.ts should become <name-of-plugin>-common.ts
  • the Common class should be named just named <NameOfPlugin>

Also the platform specific files should have export * from './<name-of-plugin>-common.ts'

@PeterStaev
Copy link
Author

also the class that is in the .d.ts file should be just export class <NameOfPlugin> instead of export declare class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants