Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sound from custom goat horns #87

Open
Abbinabb opened this issue Jan 15, 2025 · 2 comments
Open

No sound from custom goat horns #87

Abbinabb opened this issue Jan 15, 2025 · 2 comments

Comments

@Abbinabb
Copy link

It has a section for goat horns and player head but when we add a sound to the goat horns no matter the length or volume it's silent when it's played. It doesn't even play the regular sound.

@Navoei
Copy link
Owner

Navoei commented Jan 16, 2025

I removed those due to these types of changes being outside of what I know. In other words, I don't know of a way to proper implement these.

@Athar42
Copy link
Contributor

Athar42 commented Jan 25, 2025

Just a few extra details here :

  • Initial implementation (that I wasn't thinking to see it "merged" right away as this was a working but messy Proof of Concept more than anything else 😁 ) got removed in latest versions.

  • I'm still in the work of making it a reality, but Paper did lack of some API features (it's on the tracks with them, so that we should be able to implement a better way to handle Goat Horns in the future).

THERE IS NOT ETA as in when PaperMC teams and contributors will make it a reality, but I'm still trying to "push" them to advance on those changes 😅

There is still the definitions in the plugin to "change" the volume for players head or goat horns, but that will have no effects right now and I don't think it's a reason to change the code for this and publish a new release just for a cosmetic change (as this doesn't interfer with the rest of the plugins, so that's fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants