Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Set foldcolumn=0 by default #1507

Closed
igorlfs opened this issue Oct 16, 2024 · 4 comments
Closed

[Feature Request] Set foldcolumn=0 by default #1507

igorlfs opened this issue Oct 16, 2024 · 4 comments

Comments

@igorlfs
Copy link

igorlfs commented Oct 16, 2024

Is your feature request related to a problem? Please describe.
When foldcolumn is set to a value other than "0", duplicate signs may be shown, e.g.

image

Describe the solution you'd like
set foldcolumn=0 by default for Neogit related buffers

Describe alternatives you've considered
So far, I've been using an autocmd to set the foldcolumn, which works fine for me, but I think the default experience could be improved with this setting.

Additional context
Relates to #1258 and #1400

@CKolkey
Copy link
Member

CKolkey commented Oct 17, 2024

Yea, good call. Done in 3e44062

@CKolkey CKolkey closed this as completed Oct 17, 2024
@igorlfs
Copy link
Author

igorlfs commented Oct 18, 2024

Hey there! Thanks for the fix! I was wondering if the fix could also be applied to other Neogit related buffers, such as the NeogitCommitView, the NeogitLogView and so on. IMO the foldcolumn doesn't convey any info for these buffers and just fills space.

@CKolkey
Copy link
Member

CKolkey commented Oct 18, 2024

Sure :)

@windowsrefund
Copy link

TBH, I think this should be undone as it overrides a setup where foldcolumn is set to auto. Honestly, I think foldcolumn is more useful than signcolumn which I've disabled with disable_sign = true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants