Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show graph like Git Graph #1560

Open
uwla opened this issue Nov 15, 2024 · 4 comments
Open

Show graph like Git Graph #1560

uwla opened this issue Nov 15, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@uwla
Copy link

uwla commented Nov 15, 2024

Is your feature request related to a problem? Please describe.
Git Graph by https://github.com/isakbm/gitgraph.nvim has nice alignment and is visually more appealing than the log and graph rendered by NeoGit.

Describe the solution you'd like
Allow using GitGraph as a backend to render the graphs. Select the options using NeoGit (just as it is currently done), then make a call to gitgraph drawing require'gitgraph'.draw({}, {}) function and use it to render the log messages.

Describe alternatives you've considered
Quitting NeoGit and calling GitGraph, but that's a poor workflow because I prefer to use NeoGit except for viewing logs.

@CKolkey
Copy link
Member

CKolkey commented Nov 15, 2024

Already done - set the graph style to "kitty" and... use kitty :)

@CKolkey CKolkey closed this as completed Nov 15, 2024
@uwla
Copy link
Author

uwla commented Nov 21, 2024

Hi @CKolkey, thanks for the feedback but that is not tue bug I was talking about.

I think I was unclear, so here is what I meant:

NeoGit log graph

The text are not aligned because it is shifted due to the git branch

neogit1

GitGraph log graph

The text are aligned and all of them are shifted the same width, regardless of branch

neogit2

Expected behavior

I love NeoGit but this misalignment is quite harmful to the eyes of people like me who like everything aligned. Please, can you add the possibility of aligning the text so it is shifted the same amount of spaces regardless of how deep the branch is ? Like the GitGraph.

@uwla
Copy link
Author

uwla commented Nov 26, 2024

@CKolkey could you reopen the issue?

@CKolkey CKolkey reopened this Nov 26, 2024
@CKolkey CKolkey added enhancement New feature or request good first issue Good for newcomers labels Nov 26, 2024
@CKolkey
Copy link
Member

CKolkey commented Nov 26, 2024

Hey - thanks for clarifying. Makes sense what you're asking, though if I'm honest I like the visual inconsistencies. But that's a matter of preference. I'm open to someone making this configurable :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants