feat: display unconfirmed balance in clients

unconfirmed balance displays in dashboard overview and there is also a
neptune-cli command

src/bin/dashboard_src/overview_screen.rs

@@ -36,6 +36,7 @@ use super::screen::Screen;
 #[derive(Debug, Clone)]
 pub struct OverviewData {
     available_balance: Option<NeptuneCoins>,
+    available_unconfirmed_balance: Option<NeptuneCoins>,
     timelocked_balance: Option<NeptuneCoins>,
     confirmations: Option<BlockHeight>,
     synchronization_percentage: Option<f64>,
@@ -73,6 +74,7 @@ impl OverviewData {
     pub fn new(network: Network, listen_address: Option<SocketAddr>) -> Self {
         Self {
             available_balance: Default::default(),
+            available_unconfirmed_balance: Default::default(),
             timelocked_balance: Default::default(),
             confirmations: Default::default(),
             synchronization_percentage: Default::default(),
@@ -102,6 +104,7 @@ impl OverviewData {
     pub async fn test() -> Self {
         OverviewData {
             available_balance: Some(NeptuneCoins::zero()),
+            available_unconfirmed_balance: Some(NeptuneCoins::zero()),
             timelocked_balance: Some(NeptuneCoins::zero()),
             confirmations: Some(17.into()),
             synchronization_percentage: Some(99.5),
@@ -218,6 +221,7 @@ impl OverviewScreen {
                                 own_overview_data.authenticated_peer_count=Some(0);
                                 own_overview_data.syncing=resp.syncing;
                                 own_overview_data.available_balance = Some(resp.available_balance);
+                                own_overview_data.available_unconfirmed_balance = Some(resp.available_unconfirmed_balance);
                                 own_overview_data.timelocked_balance = Some(resp.timelocked_balance);
                                 own_overview_data.is_mining = resp.is_mining;
                                 own_overview_data.confirmations = resp.confirmations;
@@ -382,6 +386,10 @@ impl Widget for OverviewScreen {
                 None => " ".to_string(),
             },
         ));
+        lines.push(format!(
+            "unconfirmed balance: {}",
+            dashifnotset!(data.available_unconfirmed_balance),
+        ));
         lines.push(format!(
             "time-locked balance: {}",
             dashifnotset!(data.timelocked_balance),

src/bin/neptune-cli.rs

@@ -106,6 +106,7 @@ enum Command {
         block_selector: BlockSelector,
     },
     SyncedBalance,
+    SyncedBalanceUnconfirmed,
     WalletStatus,
     OwnReceivingAddress,
     ListCoins,
@@ -415,6 +416,10 @@ async fn main() -> Result<()> {
             let val = client.synced_balance(ctx).await?;
             println!("{val}");
         }
+        Command::SyncedBalanceUnconfirmed => {
+            let val = client.synced_balance_unconfirmed(ctx).await?;
+            println!("{val}");
+        }
         Command::WalletStatus => {
             let wallet_status: WalletStatus = client.wallet_status(ctx).await?;
             println!("{}", serde_json::to_string_pretty(&wallet_status)?);

src/models/state/wallet/wallet_state.rs

@@ -328,7 +328,7 @@ impl WalletState {
         self.mempool_unspent_utxos
             .values()
             .flatten()
-            .map(|a| &a.utxo)
+            .map(|au| &au.utxo)
     }
 
     pub async fn confirmed_balance(
@@ -354,13 +354,13 @@ impl WalletState {
                     .map(|u| u.get_native_currency_amount())
                     .sum(),
             )
-            .unwrap()
+            .expect("balance must never be negative")
             .safe_add(
                 self.mempool_unspent_utxos_iter()
                     .map(|u| u.get_native_currency_amount())
                     .sum(),
             )
-            .unwrap()
+            .expect("balance must never overflow")
     }
 
     // note: does not verify we do not have any dups.
@@ -1055,6 +1055,7 @@ impl WalletState {
                 }
             }
         }
+
         WalletStatus {
             synced_unspent,
             unsynced_unspent,

src/rpc_server.rs

@@ -51,6 +51,7 @@ pub struct DashBoardOverviewDataFromClient {
     pub syncing: bool,
     pub available_balance: NeptuneCoins,
     pub timelocked_balance: NeptuneCoins,
+    pub available_unconfirmed_balance: NeptuneCoins,
     pub mempool_size: usize,
     pub mempool_tx_count: usize,
 
@@ -118,6 +119,9 @@ pub trait RPC {
     /// Get sum of unspent UTXOs.
     async fn synced_balance() -> NeptuneCoins;
 
+    /// Get sum of unspent UTXOs including mempool transactions.
+    async fn synced_balance_unconfirmed() -> NeptuneCoins;
+
     /// Get the client's wallet transaction history
     async fn history() -> Vec<(Digest, BlockHeight, Timestamp, NeptuneCoins)>;
 
@@ -571,6 +575,15 @@ impl RPC for NeptuneRPCServer {
         wallet_status.synced_unspent_available_amount(now)
     }
 
+    // documented in trait. do not add doc-comment.
+    async fn synced_balance_unconfirmed(self, _context: tarpc::context::Context) -> NeptuneCoins {
+        let gs = self.state.lock_guard().await;
+
+        gs.wallet_state
+            .unconfirmed_balance(gs.chain.light_state().hash(), Timestamp::now())
+            .await
+    }
+
     // documented in trait. do not add doc-comment.
     async fn wallet_status(self, _context: tarpc::context::Context) -> WalletStatus {
         self.state
@@ -660,6 +673,10 @@ impl RPC for NeptuneRPCServer {
         let mempool_size = state.mempool.get_size();
         let mempool_tx_count = state.mempool.len();
         let cpu_temp = Self::cpu_temp_inner();
+        let unconfirmed_balance = state
+            .wallet_state
+            .unconfirmed_balance(tip_digest, now)
+            .await;
 
         let peer_count = Some(state.net.peer_map.len());
 
@@ -674,6 +691,7 @@ impl RPC for NeptuneRPCServer {
             syncing,
             available_balance: wallet_status.synced_unspent_available_amount(now),
             timelocked_balance: wallet_status.synced_unspent_timelocked_amount(now),
+            available_unconfirmed_balance: unconfirmed_balance,
             mempool_size,
             mempool_tx_count,
             peer_count,