feat: Update tokenURI mechanism #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-supizet
approved these changes
Feb 21, 2022
contracts/NestedAsset.sol
Outdated
|
|
||
| /// @dev Stores the original asset of each asset | ||
| mapping(uint256 => uint256) public originalAsset; | ||
|
|
||
| /// @dev Stores owners of burnt assets | ||
| mapping(uint256 => address) public lastOwnerBeforeBurn; | ||
|
|
||
| /// @dev True if using the API |
There was a problem hiding this comment.
💅 "using the API" is not very explicit. Consider rewording this
Same for L20
Comment on lines
+62
to
+63
| function _baseURI() internal view override returns (string memory) { | ||
| return baseUri; |
There was a problem hiding this comment.
❔ Is this function really necessary? If used by the ERC721 contract, shouldn't it be declared in it already?
There was a problem hiding this comment.
Yes because used in super.tokenURI()
contracts/NestedAsset.sol
Outdated
Comment on lines
116
to
117
| function reveal() external onlyOwner { | ||
| isRevealed = true; |
There was a problem hiding this comment.
There is no mechanism to unreveal to correct a mistake. Consider changing this function to setIsRevealed(bool _isRevealed).
adrien-supizet
added
Fix and merge
maximebrugel
added
Can merge
obatirou
added a commit
to code-423n4/2022-06-nested
that referenced
this pull request
Jun 14, 2022
…om known issues It was handled in MassDotMoney/nested-core-lego#103
obatirou
added a commit
to code-423n4/2022-06-nested
that referenced
this pull request
Jun 15, 2022
It was handled in MassDotMoney/nested-core-lego#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated the mechanism to set the
tokenURI:mintWithMetadataandbackfillTokenURI(with the_tokenURIsmap).