Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner error propagation in hystrix core #1366

Closed
tjuchniewicz opened this issue Sep 27, 2016 · 6 comments
Closed

Cleaner error propagation in hystrix core #1366

tjuchniewicz opened this issue Sep 27, 2016 · 6 comments

Comments

@tjuchniewicz
Copy link

This is continuation of #241 which was implemented only in Javanica? Why not in Hystrix core?

@tjuchniewicz tjuchniewicz changed the title Cleaner error propagation in hystrix Cleaner error propagation in hystrix core Sep 27, 2016
@mattrjacobs
Copy link
Contributor

  1. No one has asked for it, and it's not a use-case we've needed internally
  2. Javanica is annotation-based and annotations are a natural fit for a solution here.

@tjuchniewicz
Copy link
Author

tjuchniewicz commented Sep 29, 2016

OK. So now we have one person asking for it ;-)
I've prepared fix in my private branch which solves my problem but I'm not sure if it my solution is the right place for this enhancement.

@mattrjacobs
Copy link
Contributor

I'm happy to take a look at a PR and we can see how it would work within hystrix-core.

@tjuchniewicz
Copy link
Author

Please take a look at PR: #1379

@mattrjacobs
Copy link
Contributor

I think this has been addressed via a review of #1379, which was eventually subsumed by #1414. Please reopen if there's more to discuss

@tjuchniewicz
Copy link
Author

Yes. #1414 fixed my case. Special thanks to @tbvh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants