Fix handling of UnknownOperationException #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -204,6 +205,17 @@ internal class DefaultDgsQueryExecutorTest { | |||
| .isInstanceOf(InvalidSyntaxError::class.java) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `Invalid operation returns a GraphQL Error with type UnknownOperationException`() { | |||
There was a problem hiding this comment.
Should we also check that the status is set to BAD_REQUEST?
There was a problem hiding this comment.
I've added an assertion for that.
Emily
approved these changes
Jan 8, 2024
When GraphQL.executeAsync throws UnknownOperationException, or any exception implementing GraphQLError, set the status to BAD_REQUEST / 400 in BaseDgsQueryExecutor. Fixes #1751.
kilink
force-pushed
the
unknown-operation-fix
branch
from
19cd3c5 to
b9b3479
Compare
srinivasankavitha
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GraphQL.executeAsync throws UnknownOperationException, or any exception implementing GraphQLError, set the status to BAD_REQUEST / 400 in BaseDgsQueryExecutor. Fixes #1751.