Inject schema resources from spring-graphql into DgsSchemaProvider. #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbakker
reviewed
Jan 15, 2024
| } | ||
| } | ||
|
|
||
| private fun computeSchema(schema: String? = null, fieldVisibility: GraphqlFieldVisibility): GraphQLSchema { | ||
| private fun computeSchema(schema: String? = null, schemaResources: Set<Resource>? = emptySet(), fieldVisibility: GraphqlFieldVisibility): GraphQLSchema { |
There was a problem hiding this comment.
minor:
- Don't make it nullable - it can just be an empty set by default, so we don't have to null check.
- Make it the third argument. The existing fieldVisibility argument is non-optional. If this new one is the last argument and it has a default value, you don't have to specify it, so for example the DgsAutoConfiguration can stay unchanged.
paulbakker
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Inject schema resources from spring-graphql into DgsSChemaResourceProvider so those can be parsed as well.