Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dark Mode #435

Closed
lostgeek opened this issue Jun 6, 2020 · 3 comments · Fixed by #788
Closed

Feature Request: Dark Mode #435

lostgeek opened this issue Jun 6, 2020 · 3 comments · Fixed by #788
Labels
enhancement Describes a "nice to have" feature, rather than a functional defect.

Comments

@lostgeek
Copy link

lostgeek commented Jun 6, 2020

There are Firefox Plugins like Dark Reader that enable you to dynamically create dark themes for any website. It does a pretty good job on NRDB (see screenshots attached), but has two main issues: Influence pips between Weyland and Neutral cards are indistinguishable. Also buttons are not easily readable in their on/off state (especially those showing how many copies of a card you include in your deck).
It would be cool to have a well-made dark mode option inbuilt to NRDB.

image
image

@plural plural added the enhancement Describes a "nice to have" feature, rather than a functional defect. label Aug 6, 2020
@plural plural added this to the General UI Improvements milestone Aug 6, 2020
@tzanetl
Copy link

tzanetl commented Nov 16, 2023

Dark Reader works wonderfully, except for the hover on card display

image

I tried to figure out the correct css tags to modify to fix the inversion, but for the life of me I couldn't do it. If anyone knows which tags to are responsible, a fix could be submitted to Dark Reader.

@AlexRodwell AlexRodwell mentioned this issue Dec 29, 2023
@AlexRodwell
Copy link
Contributor

Working on addressing this feature request in my draft pull-request #788 using CSS variables. I'm using Dark Reader's dark theme as a base for the colour swaps for dark mode, although this might change before merging.

@AlexRodwell AlexRodwell linked a pull request Dec 30, 2023 that will close this issue
@francescopellegrini
Copy link
Contributor

Thank you so much for this feature, really appreciated! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Describes a "nice to have" feature, rather than a functional defect.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants