Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak cleanup procedure #2

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Tweak cleanup procedure #2

merged 2 commits into from
Aug 5, 2024

Conversation

trz42
Copy link

@trz42 trz42 commented Aug 5, 2024

Suggestions for the clean up procedure:

  • use shutil.move instead of shutil.copytree
  • use configuration setting for PR comment and put all configuration settings introduced into one section
  • check for required configuration settings (eessi_bot_event_handler.py only)
  • add information about settings in README.md and app.cfg.example

truib added 2 commits August 5, 2024 14:15
@truib
tweak clean up method by
71e7b31 
- putting configuration settings into a single section
- using shutil.move instead of shutil.copy (move should fallback to copy
  if moving is not doable)
@truib
add information to README.md and app.cfg.example
d1a0278
@trz42 trz42 mentioned this pull request Aug 5, 2024
Merged
2 tasks
@Neves-P
Copy link
Owner

Neves-P commented Aug 5, 2024

Looks great, thanks! I'd forgotten the app.cfg.example and config settings 🤦

@Neves-P Neves-P merged commit 1bc2bf4 into Neves-P:feature/disk_cleanup Aug 5, 2024
Neves-P pushed a commit that referenced this pull request Aug 7, 2024
@Neves-Bot
Merge pull request #2 from Neves-P/feature/disk_cleanup
1d87ea2 
Feature/disk cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trz42 @Neves-P @truib