-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/TripPlace_Accommodation: 페이지 동적 경로 설정 및 storage 재수정 사항 반영 #75
Merged
hyeonjuuu
merged 9 commits into
WeonTrip-WonT:develop
from
uniS2:feat/tripplace_accommodation
Mar 11, 2024
Merged
Feat/TripPlace_Accommodation: 페이지 동적 경로 설정 및 storage 재수정 사항 반영 #75
hyeonjuuu
merged 9 commits into
WeonTrip-WonT:develop
from
uniS2:feat/tripplace_accommodation
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 변경 전 state: `[ {'1': [{데이터}, {데이터}, ... ]}, {...}, ...]` - 변경 후 state: `[ [{데이터}, {데이터}, ...], [...], .. ]` - `setSelctedPlaces` action 수정 - `resetSelectedPlaces` action 삭제 Github issue WeonTrip-WonT#59
- 동적 경로 적용: `[tripdate]` - `useParams()` 이용하여 tripDate, index 값 하위 컴포넌트에 전달 - 각 컴포넌트에서 `useParams()`를 불러와 관리할지 고민입니다. Github issue WeonTrip-WonT#59
- `isSelected` state: `useState()` 훅으로 상태 관리 Github issue WeonTrip-WonT#59
- 동적 경로 적용: `[tripdate]` Github issue WeonTrip-WonT#55
- 변경 전 state: `[ {'1': [{데이터}, {데이터}, ... ]}, {...}, ...]` - 변경 후 state: `[ [{데이터}, {데이터}, ...], [...], .. ]` - `setSelctedAccommodations` action 수정 - `resetSelectedAccommodations` action 삭제 Github issue WeonTrip-WonT#59
- `useParams()` 이용하여 tripDate, index 값 하위 컴포넌트에 전달 - 각 컴포넌트에서 `useParams()`를 불러와 관리할지 고민입니다. Github issue WeonTrip-WonT#59
hyeonjuuu
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
소이님 정말 고생 많으셨습니다..ㅠㅠ 저도 나머지 로직 구현해보겠습니다! 감사합니다!!!
6 tasks
6 tasks
This was
linked to
issues
Mar 17, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
related #55 #57 #59
작업 내용
(관광)장소 / 숙소 storage state 재수정 사항 반영 및 reset action 삭제 (불필요)
TripPlace, TripAccommodation 페이지 동적 경로 적용:
[tripdate]
useParams()
이용 하여 tripDate, index 값 하위 컴포넌트에 전달달성도
😀 To. @hyeonjuuu 님 storage 맞게 title 값 렌더링되고 있는거 확인했습니다.
![state 구조](https://private-user-images.githubusercontent.com/134567469/311649834-f1c1cba1-f4f9-44ca-8399-66e8a9d1b2fe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MzQ5MzgsIm5iZiI6MTczOTQzNDYzOCwicGF0aCI6Ii8xMzQ1Njc0NjkvMzExNjQ5ODM0LWYxYzFjYmExLWY0ZjktNDRjYS04Mzk5LTY2ZThhOWQxYjJmZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwODE3MThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YWZhZjhkY2QwMTI5ZWFlZDhiMmU4NzcxOTI4YjFjYzJkOGQwYTdjYjdlMWJjOWEyYTdjNTExODZkZjNiN2UzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.QhZ3Ou5rPSMW-59Fydem_n1Fdj8x2Wnjm6rpGjJuQ0U)
세부적으로 페이지 맞게 렌더링되도록 수정만 하면 될 거 같아요! 파이팅 😎
PR 체크리스트