Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unnecessary panics #1125

Closed
6 tasks done
Unique-Divine opened this issue Dec 28, 2022 · 1 comment
Closed
6 tasks done

refactor: Remove unnecessary panics #1125

Unique-Divine opened this issue Dec 28, 2022 · 1 comment
Labels
epic Project or large task that groups multiple tickets and PRs

Comments

@Unique-Divine
Copy link
Member

Unique-Divine commented Dec 28, 2022 •
edited
Loading

Summary

The only places that can/should panic are on the module.AppModule interface, more specifically, in the following functions:

  1. Genesis functions and any of the functions used within them (e.g. SetParams): 
    InitGenesis(sdk.Context, codec.JSONCodec, json.RawMessage) []abci.ValidatorUpdate
ExportGenesis(sdk.Context, codec.JSONCodec) json.RawMessage
  2. BeginBlock and EndBlock

High-priority Modules

  • dex
  • oracle
  • perp
  • vpool
  • pricefeed
  • stablecoin
@Unique-Divine Unique-Divine added epic Project or large task that groups multiple tickets and PRs refactor labels Dec 28, 2022
This was referenced Jan 2, 2023
Merged
Merged
@NibiruHeisenberg
Copy link
Contributor

I would argue that BeginBlock and EndBlock shouldn't panic either.

This was referenced Jan 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic Project or large task that groups multiple tickets and PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Unique-Divine @NibiruHeisenberg