bug: useless error when joining the amm pool

[onikonychev]

I just tried joining the pool with a wrong token_in and got:

recovered: division by zero\nstack:\ngoroutine 290 [running]:\nruntime/debug.Stack()\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/runtime/debug/stack.go:24 +0x65\ngithub.com/cosmos/cosmos-sdk/baseapp.newDefaultRecoveryMiddleware.func1({0x23165c0, 0x2fc4e60})\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:71 +0x27\ngithub.com/cosmos/cosmos-sdk/baseapp.newRecoveryMiddleware.func1({0x23165c0?, 0x2fc4e60?})\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:39 +0x30\ngithub.com/cosmos/cosmos-sdk/baseapp.processRecovery({0x23165c0, 0x2fc4e60}, 0xc0613ff200?)\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:28 +0x37\ngithub.com/cosmos/cosmos-sdk/baseapp.processRecovery({0x23165c0, 0x2fc4e60}, 0x2ff97f8?)\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/recovery.go:33 +0x5e\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx.func1()\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/baseapp.go:632 +0x110\npanic({0x23165c0, 0x2fc4e60})\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/runtime/panic.go:884 +0x212\nmath/big.nat.div({0x0?, 0xc061db3980?, 0x0?}, {0x0?, 0xc0018b5940?, 0x430447?}, {0xc067a76a80?, 0x2475560?, 0xc061db3801?}, {0x0, ...})\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/math/big/natdiv.go:507 +0x34b\nmath/big.(*Int).Quo(0xc061db3980, 0xc061db3940, 0xc061db3960)\n\t/opt/hostedtoolcache/go/1.19.5/x64/src/math/big/int.go:211 +0x78\ngithub.com/cosmos/cosmos-sdk/types.Dec.QuoInt(...)\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/types/decimal.go:340\ngithub.com/NibiruChain/nibiru/x/spot/types.Pool.numSharesOutFromTokensIn({0x1, {0xc067a76990, 0x2b}, {{0xc061db37c0}, {0xc061db37e0}, {0xc061db3800}, 0x0}, {0xc061da5b40, 0x2, 0x2}, ...}, ...)\n\t/home/runner/work/nibiru/nibiru/x/spot/types/shares.go:53 +0xa08\ngithub.com/NibiruChain/nibiru/x/spot/types.(*Pool).AddTokensToPool(0xc0018b66c8, {0xc061fbc120, 0x2, 0x2})\n\t/home/runner/work/nibiru/nibiru/x/spot/types/pool.go:107 +0x145\ngithub.com/NibiruChain/nibiru/x/spot/types.(*Pool).AddAllTokensToPool(0xc0018b66c8, {0xc061fbc120?, 0x2b?, 0xc061db37c0?})\n\t/home/runner/work/nibiru/nibiru/x/spot/types/pool.go:145 +0x37\ngithub.com/NibiruChain/nibiru/x/spot/keeper.Keeper.JoinPool({{0x2ffa0e0, 0xc0010794a0}, {0x2fcf5b8, 0xc000fa25d0}, {{0x2ffa0e0, 0xc0010794a0}, 0xc0005a5088, {0x2fcf5b8, 0xc000fa2550}, {0x2fcf608, ...}, ...}, ...}, ...)\n\t/home/runner/work/nibiru/nibiru/x/spot/keeper/keeper.go:466 +0x258\ngithub.com/NibiruChain/nibiru/x/spot/keeper.msgServer.JoinPool({{{0x2ffa0e0, 0xc0010794a0}, {0x2fcf5b8, 0xc000fa25d0}, {{0x2ffa0e0, 0xc0010794a0}, 0xc0005a5088, {0x2fcf5b8, 0xc000fa2550}, {0x2fcf608, ...}, ...}, ...}}, ...)\n\t/home/runner/work/nibiru/nibiru/x/spot/keeper/msg_server.go:75 +0x276\ngithub.com/NibiruChain/nibiru/x/spot.NewHandler.func1({{0x2fe9218, 0xc07b2c6450}, {0x2ff97f8, 0xc061da5b00}, {{0xb, 0x0}, {0xc0619951b0, 0xc}, 0x2e70a, {0x35f9a19a, ...}, ...}, ...}, ...)\n\t/home/runner/work/nibiru/nibiru/x/spot/handler.go:26 +0x242\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runMsgs(, {{0x2fe9218, 0xc07b2c6450}, {0x2ff97f8, 0xc061da5b00}, {{0xb, 0x0}, {0xc0619951b0, 0xc}, 0x2e70a, ...}, ...}, ...)\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/baseapp.go:775 +0x768\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx(0xc0005eafc0, 0x3, {0xc05fd2d180, 0x129, 0x129})\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/baseapp.go:717 +0xd0c\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).DeliverTx(0xc0005eafc0, {{0xc05fd2d180?, 0x20?, 0xc026fa68c0?}})\n\t/home/runner/go/pkg/mod/github.com/cosmos/[email protected]/baseapp/abci.go:285 +0x205\ngithub.com/tendermint/tendermint/abci/client.(*localClient).DeliverTxAsync(0xc000dbc5a0, {{0xc05fd2d180?, 0x0?, 0xc000dbc5a0?}})\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/abci/client/local_client.go:93 +0x105\ngithub.com/tendermint/tendermint/proxy.(*appConnConsensus).DeliverTxAsync(0xc0760aca80?, {{0xc05fd2d180?, 0x20?, 0xb?}})\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/proxy/app_conn.go:85 +0x26\ngithub.com/tendermint/tendermint/state.execBlockOnProxyApp({0x2fea440?, 0xc00106b1a0}, {0x2ff3440, 0xc000fa23c0}, 0xc021f363c0, {0x2ffb600, 0xc00b6f8570}, 0x2e709?)\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/state/execution.go:320 +0x847\ngithub.com/tendermint/tendermint/state.(*BlockExecutor).ApplyBlock(, {{{0xb, 0x0}, {0xc0029c0d50, 0x8}}, {0xc0029c0d60, 0xc}, 0x1, 0x2e709, {{0xc0566ab320, ...}, ...}, ...}, ...)\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/state/execution.go:140 +0x171\ngithub.com/tendermint/tendermint/consensus.(*State).finalizeCommit(0xc000e20000, 0x2e70a)\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:1654 +0xafd\ngithub.com/tendermint/tendermint/consensus.(*State).tryFinalizeCommit(0xc000e20000, 0x2e70a)\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:1563 +0x2ff\ngithub.com/tendermint/tendermint/consensus.(*State).enterCommit.func1()\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:1498 +0x94\ngithub.com/tendermint/tendermint/consensus.(*State).enterCommit(0xc000e20000, 0x2e70a, 0x0)\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:1536 +0xccf\ngithub.com/tendermint/tendermint/consensus.(*State).addVote(0xc000e20000, 0xc07643ae60, {0xc005167ad0, 0x28})\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:2150 +0x18dc\ngithub.com/tendermint/tendermint/consensus.(*State).tryAddVote(0xc000e20000, 0xc07643ae60, {0xc005167ad0?, 0xc060351200?})\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:1948 +0x2c\ngithub.com/tendermint/tendermint/consensus.(*State).handleMsg(0xc000e20000, {{0x2fc8fc0?, 0xc064334e40?}, {0xc005167ad0?, 0x0?}})\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:853 +0x170\ngithub.com/tendermint/tendermint/consensus.(*State).receiveRoutine(0xc000e20000, 0x0)\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:760 +0x3f9\ncreated by github.com/tendermint/tendermint/consensus.(*State).OnStart\n\t/home/runner/go/pkg/mod/github.com/tendermint/[email protected]/consensus/state.go:379 +0x12d\n: panic"