Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] pre countdown timer even when option is disabled #1370

Open
deontic opened this issue Feb 19, 2025 · 3 comments
Open

[Bug] pre countdown timer even when option is disabled #1370

deontic opened this issue Feb 19, 2025 · 3 comments
Assignees
Labels
🔷 Bug 🐛 Type • An undesired situation happens. ⬜ Pending Status • This issue stills needs to be analyzed.

Comments

@deontic
Copy link

deontic commented Feb 19, 2025

There is a countdown timer after recording begins even when the relevant option is disabled, only when you record after supplying an arbitrary size by selecting a region on the screen.

To Reproduce
select a region on your screen , and start record
Expected behavior
timer is not expected when not enabled

@deontic deontic added ⬜ Pending Status • This issue stills needs to be analyzed. 🔷 Bug 🐛 Type • An undesired situation happens. labels Feb 19, 2025
@pawlos
Copy link
Contributor

pawlos commented Feb 19, 2025

@deontic are we talking about this option?

Image

It seems to work ok for me? How does the countdown timer shows up with the option being off? Is it on the latest version?

@deontic
Copy link
Author

deontic commented Feb 20, 2025

Yes, I said when this option is disabled, the countdown timer shows up. This is the latest version. I said it appears only when you select a region on the screen manually:

Recorder:

Timer visible:

---

Timer option disabled:


How does the countdown timer shows up with the option being off?

Wondering the same)

@pawlos
Copy link
Contributor

pawlos commented Feb 20, 2025

How does the countdown timer shows up with the option being off?

Wondering the same)

@deontic I was asking about what exact message you see - the 2nd screenshot. From that I can see that this message is shown in case the recorded area intersects with the recording controls and it does inform that they will be hidden and provide you with the shortcut that does allow you to stop the recording.
The code condition to use the pre recording count down check if the option is on OR the recorded area intersects with the controls (so it's not limited to only the case when the area is selected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔷 Bug 🐛 Type • An undesired situation happens. ⬜ Pending Status • This issue stills needs to be analyzed.
Projects
None yet
Development

No branches or pull requests

3 participants