Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when select current month #779

Closed
cassiogomes00 opened this issue Feb 2, 2024 · 5 comments · Fixed by #780
Closed

Crash when select current month #779

cassiogomes00 opened this issue Feb 2, 2024 · 5 comments · Fixed by #780
Labels
bug Something isn't working

Comments

@cassiogomes00
Copy link
Contributor

cassiogomes00 commented Feb 2, 2024

Descriprion

Sometimes, click on the "Select Current Month" button makes the app crash with the following exception:

UnhandledException - unhandled exception: System.ArgumentOutOfRangeException: Year, Month, and Day parameters describe an un-representable DateTime.
   at System.DateOnly..ctor(Int32 year, Int32 month, Int32 day)
   at NickvisionMoney.GNOME.Views.AccountView.OnDateRangeEndYearChanged() in /run/build/org.nickvision.money/NickvisionMoney.GNOME/Views/AccountView.cs:line 1318
   at NickvisionMoney.GNOME.Views.AccountView.<.ctor>b__70_28(Object sender, NotifySignalArgs e) in /run/build/org.nickvision.money/NickvisionMoney.GNOME/Views/AccountView.cs:line 252
   at GObject.Closure.InternalCallback(IntPtr closure, IntPtr returnValuePtr, UInt32 nParamValues, ValueData[] paramValuesData, IntPtr invocationHint, IntPtr userData)

How to reproduce

  • Open an account
  • Mess arround with viewing/filtering options (can't tell exactly with action(s) trigger the error)
  • Click on the "Select Current Month" button

Expected behaviour

Filter transaction by the month selected in the calendar widget

System Info

Hardware Information:

  • Hardware Model: ASUS TUF GAMING B550M-PLUS WIFI II
  • Memory: 32,0 GiB
  • Processor: AMD Ryzen™ 5 5600 × 12
  • Graphics: AMD Radeon™ RX 550 / 550 Series
  • Disk Capacity: 1,0 TB

Software Information:

  • Firmware Version: 3002
  • OS Name: Arch Linux
  • OS Build: rolling
  • OS Type: 64-bit
  • GNOME Version: 45.3
  • Windowing System: Wayland
  • Kernel Version: Linux 6.7.1-arch1-1
  • Formats: Brasil

App Information

  • Version: 2024.1.0
  • Package: Flatpak
  • Source: Flathub
@JoseBritto JoseBritto added the bug Something isn't working label Feb 2, 2024
@JoseBritto
Copy link
Member

Thanks for reporting this bug.

Reproducing consistently:

  1. Click show current month when on February 2024
  2. Change end year from 2024 Feb 29 to 2023 Feb 29 (impossible date)
  3. Crash!

@cassiogomes00
Copy link
Contributor Author

cassiogomes00 commented Feb 2, 2024

I found another way to reproduce it consistently:

  1. Go to a February 2024 day
  2. Click "Select Current Month"
  3. Click "Reset To Today"
  4. Click "Select Current Month"
  5. Crash

It doesn't crash if, in the first step, a day of another month is selected (but clicking on reset to today works as a first step too)

@JoseBritto
Copy link
Member

Seems like that one too is the same bug. It's not happening on #780 branch. If possible would you be able to confirm the pr fixes it?

@nlogozzo
Copy link
Member

nlogozzo commented Feb 2, 2024

Probably going to release the hot fix since this is probably affecting everyone

@nlogozzo
Copy link
Member

nlogozzo commented Feb 2, 2024

https://github.com/NickvisionApps/Denaro/releases/tag/2024.2.0

Will be available through Flathub in 20 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants