Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect better #4

Closed
erisu opened this issue Sep 3, 2020 · 11 comments
Closed

Detect better #4

erisu opened this issue Sep 3, 2020 · 11 comments

Comments

@erisu
Copy link
Collaborator

erisu commented Sep 3, 2020

Give me my release!
ASAP!!
NOW!
OMG PLEASE!!!
I AM BEGGING YOU!!!
RELEASE!!!

@NiklasMerz NiklasMerz transferred this issue from NiklasMerz/release-test Sep 3, 2020
@timbru31
Copy link
Collaborator

timbru31 commented Sep 3, 2020

And when do you enable for Apache

@NiklasMerz
Copy link
Owner

NiklasMerz commented Sep 3, 2020

Maybe we should adjust this:

const penalties = [
{search: 'npm', penalty: 5},
{search: 'release', penalty: 3},
{search: 'new version', penalty: 2},
{search: 'tag', penalty: 2}

And check for stuff in all CAPS :-)

@NiklasMerz
Copy link
Owner

And when do you enable for Apache

Do we have consensus that this is a good idea? Should we test it in one repo first?

@NiklasMerz NiklasMerz changed the title Release Detect better Sep 3, 2020
@erisu
Copy link
Collaborator Author

erisu commented Sep 3, 2020

Please put this into Camera first at least :D

@erisu
Copy link
Collaborator Author

erisu commented Sep 3, 2020

I even just started the thread for next release and they still asking :(

@NiklasMerz
Copy link
Owner

Then let's use Camera as a proving ground.

@erisu
Copy link
Collaborator Author

erisu commented Sep 3, 2020

consensus wise, most people didn't even leave a comment. I can leave a comment with a +1 to try and reactive the vote/discussion.. I am for it if we can improve

@erisu
Copy link
Collaborator Author

erisu commented Sep 3, 2020

I always been trying to improve the issue tracker/management but fail to get consensus or votes..

@NiklasMerz
Copy link
Owner

Let's test it out and see how it works. Then we can roll it out to other repos after collecting consensus. Another improvement would be to add a comment about this behavior to contributin:

PR for camera: apache/cordova-plugin-camera#654

@NiklasMerz
Copy link
Owner

I invited you to this repo if you want to make any changes. Hopefully I find some time tonight to improve this a bit.

@NiklasMerz
Copy link
Owner

I just did some changes and added some random penalties

@erisu erisu closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants