Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the no-url-literals experimental feature #10048

Open
thufschmitt opened this issue Feb 20, 2024 · 2 comments
Open

Remove the no-url-literals experimental feature #10048

thufschmitt opened this issue Feb 20, 2024 · 2 comments
Labels
feature Feature request or proposal idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.

Comments

@thufschmitt
Copy link
Member

Is your feature request related to a problem? Please describe.

Nix currently has a no-url-literals experimental feature that disables the use of URL literals in the language.
While the change by itself is something we agree we want to move towards, having it be an experimental feature isn't the right thing because it's unlikely that we'll ever flip the switch, and it isn't visible by default.

Describe the solution you'd like

What we should instead have is have it be (visibly) deprecated (through warnings), with a way to forbid it altogether, and a way to shut the warnings if needed.

-- End of the team discussion, the below is my own interpretation of the agreement we had and up to discussion --

Concretely, we should remove the experimental feature, and add an option warn-url-literal = {yes|no|error}, defaulting to yes, with the (long-term) plan of making it default to error.

This could be later extended to a more generic mechanism able to handle more warning/errors. Tvix has a few of them, and there are a number of things discussed here that are blocked on the lack of a deprecation path (#7578, #8738, #8613)

Priorities

Add 👍 to issues you find important.

@thufschmitt thufschmitt added feature Feature request or proposal idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome. labels Feb 20, 2024
@edolstra
Copy link
Member

Yeah, it should be generalized, e.g. warnings = url-literals .... And then there could be an flag like gcc's -Werror to convert warnings into errors.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-02-19-nix-team-meeting-minutes-126/40308/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or proposal idea approved The given proposal has been discussed and approved by the Nix team. An implementation is welcome.
Projects
None yet
Development

No branches or pull requests

3 participants