Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake.nix uses outdated 22.05 nixos release for tests #7506

Closed
trofi opened this issue Dec 23, 2022 · 3 comments
Closed

flake.nix uses outdated 22.05 nixos release for tests #7506

trofi opened this issue Dec 23, 2022 · 3 comments
Labels

Comments

@trofi
Copy link
Contributor

trofi commented Dec 23, 2022

This causes a few issues:

  1. It masks the fact that submodule tests fail to run on modern git
  2. It brings binutils/gold failures in CI that were fixed in binutils upstream. Example ICE in ld.gold: https://github.com/NixOS/nix/actions/runs/3691026206/jobs/6248648814

I think it comes from:

$ fgrep 22.05 flake.nix
  inputs.nixpkgs.url = "github:NixOS/nixpkgs/nixos-22.05-small";

I did not manage to bump it to 22.11 as git submodule tests look non-trivial. Fun fact: in nixpkgs git tests are skipped as git is not added to nativeBuildInputs.

I can propose a PR with disable submodule tests. WDYT?

@trofi trofi added the bug label Dec 23, 2022
@cole-h
Copy link
Member

cole-h commented Dec 24, 2022

Is this still an issue now that #7367 has merged?

@trofi
Copy link
Contributor Author

trofi commented Dec 24, 2022

Ah, nice! Looks good enough. There are a few minor warnings in use of outdated options but they can be handled separately:

$ nix flake check
trace: warning: The option `nix.useSandbox' defined in `makeTest parameters' has been renamed to `nix.settings.sandbox'.
trace: warning: The option `nix.useSandbox' defined in `makeTest parameters' has been renamed to `nix.settings.sandbox'.
...

Thank you!

@trofi trofi closed this as completed Dec 24, 2022
@trofi
Copy link
Contributor Author

trofi commented Dec 24, 2022

Sent #7507 to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants