Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request checklist #7538

Closed
roberth opened this issue Jan 2, 2023 · 0 comments · Fixed by #7577
Closed

Pull request checklist #7538

roberth opened this issue Jan 2, 2023 · 0 comments · Fixed by #7577
Labels
contributor-experience Developer experience for Nix contributors process Issues related to the development process of Nix

Comments

@roberth
Copy link
Member

roberth commented Jan 2, 2023

Is your feature request related to a problem? Please describe.

Checklists help with guiding a process to completion. They ensure quality and make their users confident, because they won't forget certain aspects of the process.

Describe the solution you'd like

Add a pull requests checklist to the pull request template and/or "maintainer handbook" (the manual or maintainers/*.md)

Describe alternatives you've considered

  • Keep forgetting to do certain things leading to
    • bloat
    • regressions
    • forgotten documentation
    • uncertainty as to why changes to the code were made
    • prs getting slowed by delays, reminders and more delays

Have a github action that posts the checklist to each PR. This is a bit more robust as contributors may mess with the checklist.

Additional context

Priorities

Add 👍 to issues you find important.

@roberth roberth added contributor-experience Developer experience for Nix contributors process Issues related to the development process of Nix labels Jan 2, 2023
@roberth roberth mentioned this issue Jan 2, 2023
@thufschmitt thufschmitt moved this to 🏗 To discuss in Nix team Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor-experience Developer experience for Nix contributors process Issues related to the development process of Nix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant