Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter build tests #262507

Open
hacker1024 opened this issue Oct 21, 2023 · 1 comment
Open

flutter build tests #262507

hacker1024 opened this issue Oct 21, 2023 · 1 comment
Assignees
@hacker1024
Labels
0.kind: enhancement Add something new

Comments

@hacker1024
Copy link
Member

hacker1024 commented Oct 21, 2023 •
edited
Loading

Issue description

We should add tests to the flutter derivation that run flutter build for every supported platform (currently Android, Web, and Linux).

This will avoid issues like #260278 - such an obvious and disruptive regression should never have made it past review.

@NixOS/flutter
@hacker1024 hacker1024 self-assigned this Oct 21, 2023
@hacker1024 hacker1024 added the 0.kind: enhancement Add something new label Oct 21, 2023
@FlafyDev
Copy link
Contributor

I agree, there is a great need for tests.

How should the tests work?

We correctly have a builder for Linux, but I don't think this is enough testing for the Linux platform. I wonder if we could make some of the test derivations have internet access and be impure. This way we'd be able to mimic how the user will run and use flutter the best, and be able to test platforms we don't correctly have builders for.

@FlafyDev FlafyDev mentioned this issue Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacker1024 hacker1024

Labels
0.kind: enhancement Add something new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hacker1024 @FlafyDev