Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

by-name check failures are an illegible mess #266930

Closed
ghost opened this issue Nov 11, 2023 · 4 comments
Closed

by-name check failures are an illegible mess #266930

ghost opened this issue Nov 11, 2023 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 11, 2023

srsl ppl wtf

screenshot-20231111-153404

@FliegendeWurst
Copy link
Member

#257748 is related

@infinisil
Copy link
Member

@amjoseph-nixpkgs I really don't appreciate your tone on these issues.. Anyways this is indeed a duplicate of #257748.

@infinisil infinisil closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
@ghost
Copy link
Author

ghost commented Nov 13, 2023

@amjoseph-nixpkgs I really don't appreciate your tone on these issues

I mean do you want to read what's shown in the screenshot above?

I sorta don't appreciate the way the pkgs/by-name checks have morphed into a gatekeeping mechanism, and I'm particularly peeved about the fact that we spent ~2 hours on IRC discussing how to make all of this deterministic and not github-dependent -- a discussion where we clearly seemed to agree on the way forward. Then you just sort of ignored all of that, implemented the checks in github-ese, and didn't let me know or even request a review.

So yeah, there are a lot of things I don't appreciate about what's going on with the pkgs/by-name checks.

@ghost ghost reopened this Nov 13, 2023
@infinisil
Copy link
Member

That's no reason to be double-tracking issues though. But also this is now fixed since #267048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants