Headscale base_domain assertion is more strict than package's configuration check

[mtoohey31]

Describe the bug

Now that #358255 has been merged, Headscale's overly strict base_domain assertion (see juanfont/headscale#2210 for more discussion) has been fixed in the headscale package, but the corresponding assertion here:

nixpkgs/nixos/modules/services/networking/headscale.nix

Lines 562 to 571 in 3f0584a

	{
	# This is stricter than it needs to be but is exactly what upstream does:
	# https://github.com/kradalby/headscale/blob/adc084f20f843d7963c999764fa83939668d2d2c/hscontrol/types/config.go#L799
	assertion =
	with cfg.settings;
	dns.use_username_in_magic_dns or false
	|| dns.base_domain == ""
	|| !lib.hasInfix dns.base_domain server_url;
	message = "server_url cannot contain the base_domain, this will cause the headscale server and embedded DERP to become unreachable from the Tailscale node.";
	}

in the NixOS module wasn't fixed. As a result, this assertion now prohibits configurations which are valid according to the headscale package.

Steps To Reproduce

Steps to reproduce the behavior:

1. Configure headscale on a NixOS system using the module with (for example) https://bar.foo.com as server_url, and just foo as the dns.base_domain.
2. Attempt to build the system. The assertion should be triggered, failing the build.

Expected behavior

The build should succeed, since the choice of server_url and base_domain above is valid according to the headscale package as of #358255.

Notify maintainers

@kradalby @Misterio77

---

Note for maintainers: Please tag this issue in your PR.

---

Add a 👍 reaction to issues you find important.

[SuperSandro2000]

Can you open a PR to reflect those changes?

[mtoohey31]

👍 I'll try to get to it at some point. If someone else has time before I do though, feel free to go ahead and do it.

[mtoohey31]

Looks like this was fixed by #374374.