Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Is adb really governed by the android sdk license? #53403

Closed
xaverdh opened this issue Jan 4, 2019 · 4 comments
Closed

Question: Is adb really governed by the android sdk license? #53403

xaverdh opened this issue Jan 4, 2019 · 4 comments

Comments

@xaverdh
Copy link
Contributor

xaverdh commented Jan 4, 2019

Setting programs.adb.enable = true atm requires accepting the android sdk license.
Is that really necessary?
At least the code at https://android.googlesource.com/platform/system/adb/
appears to be under the apache license.

@xaverdh
Copy link
Contributor Author

xaverdh commented Jan 4, 2019

Ah ok. The programs.adb option actually includes androidenv.androidPkgs_9_0.platform-tools, which explains the license. Maybe this should be documented?

@primeos
Copy link
Member

primeos commented Jan 4, 2019

Yeah, that's a bit unfortunate, the source-code is actually free but Google's Android SDK is sadly proprietary.

https://wiki.debian.org/AndroidTools:

The binaries for the Android SDK downloadable from Google have a proprietary license but the source code is free software so Debian is packaging it.

And AFAIK (didn't check the latest changes) we still don't build the components from the source-code (that would be great but unfortunately it's pretty difficult and AFAIK only Debian attempts to build them from the source-code).

@xaverdh
Copy link
Contributor Author

xaverdh commented Dec 9, 2019

Hmm, maybe adb should be added here then? Just to document, that it should probably be built from source..

@primeos
Copy link
Member

primeos commented Dec 13, 2019

@xaverdh good idea, I've created an issue for this with some information from my failed attempts (never got that far, it's probably pretty time consuming as we're missing a lot of tooling/abstractions for it): #75603.

@primeos primeos closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants