Overriding user-agent used by fetchurl

[sikmir]

Describe the bug
I'm trying to override User-Agent header used by fetchurl (#17757) using:

curlOpts = "--user-agent 'Mac OS X'";

That leads to:

curl: (28) Resolving timed out after 15001 milliseconds
curl: (6) Could not resolve host: X'
curl: (22) The requested URL returned error: 404 Not Found

That's caused by whitespaces in the 'Mac OS X' string, otherwise it works correctly (e.g. with 'Mac_OS_X').

[nixos-discourse]

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-set-user-agent-for-fetchurl/7392/2

[lheckemann]

I'm not sure this can be worked around with the way fetchurl is currently implemented: https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchurl/builder.sh#L20

This could be avoided with the help of structuredAttrs, but that work isn't complete yet.

[gdamjan]

shouldn't be enough to just add quotes around $curlOpts here:

nixpkgs/pkgs/build-support/fetchurl/builder.sh

Line 26 in 06b2789

$curlOpts

[gdamjan]

[replying to myself] obviously not. since then the two strings in "--user-agent 'Mozilla 5.0'" are considered a single argument given to curl :/

[stale]

I marked this as stale due to inactivity. → More info

[sikmir]

Still important.

[dermetfan]

Probably duplicate of #41820.

[infinisil]

Duplicate of #41820