Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clangMultiStdenv: expose lib64 and lib separately in sysroot #166977

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

peperunas
Copy link
Contributor

Description of changes

Fixes #94023

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@peperunas peperunas requested a review from matthewbauer as a code owner April 2, 2022 22:54
@peperunas peperunas changed the title Clang multilib stdenv: expose lib64 and lib separately in sysroot clangMultiStdenv: expose lib64 and lib separately in sysroot Apr 2, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 2, 2022
@peperunas
Copy link
Contributor Author

@Ericson2314, shall we merge this PR while we work on #166947?

@Ericson2314
Copy link
Member

Sure.

@Ericson2314 Ericson2314 merged commit f712cdd into NixOS:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clangMultiStdenv is unable to link i686 code
2 participants