nixos/activation: Add pre-switch checks #236375
Merged
+111
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
|
any movements on this? This is a pretty important feature to have especially since NixOS is on so many targets now |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2604 |
wegank
added
the
12.approvals: 1
jmbaur
force-pushed
the
pre-switch-checks
branch
from
66c452b to
a915366
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2678 |
jmbaur
force-pushed
the
pre-switch-checks
branch
from
a915366 to
a1ea206
Compare
jmbaur
force-pushed
the
pre-switch-checks
branch
from
a1ea206 to
c58227f
Compare
wegank
removed
the
12.approvals: 1
wegank
added
the
2.status: merge conflict
jmbaur
force-pushed
the
pre-switch-checks
branch
2 times, most recently
from
5564302 to
3503749
Compare
|
@ofborg test switchTest switchTestNg |
ofborg
bot
removed
the
2.status: merge conflict
wegank
added
the
2.status: merge conflict
jmbaur
force-pushed
the
pre-switch-checks
branch
from
3503749 to
8a395f6
Compare
|
@ofborg test switchTest switchTestNg |
jmbaur
force-pushed
the
pre-switch-checks
branch
from
8a395f6 to
22dcf23
Compare
ofborg
bot
removed
the
2.status: merge conflict
ConnorBaker
approved these changes
Nov 21, 2024
ConnorBaker
requested changes
Nov 21, 2024
There was a problem hiding this comment.
switchTestNg fails:
vm-test-run-switch-test> machine # [ 12.400333] nixos[1057]: finished switching to system configuration /nix/store/9658x4bx9cn567a04776bg9qwsbw95qr-nixos-system-other-test
vm-test-run-switch-test> (finished: must succeed: /nix/store/69vika84p4i1qpgvnqaqrmnd2hqr38dh-stderr-runner /nix/store/9658x4bx9cn567a04776bg9qwsbw95qr-nixos-system-other-test/bin/switch-to-configuration test, in 1.23 seconds)
vm-test-run-switch-test> subtest: pre-switch checks
vm-test-run-switch-test> machine: must succeed: /nix/store/69vika84p4i1qpgvnqaqrmnd2hqr38dh-stderr-runner /nix/store/9658x4bx9cn567a04776bg9qwsbw95qr-nixos-system-other-test/bin/switch-to-configuration check
vm-test-run-switch-test> machine # Usage: switch-to-configuration [check|switch|boot|test|dry-activate]
vm-test-run-switch-test> machine # check: run pre-switch checks and exit
vm-test-run-switch-test> machine # switch: make the configuration the boot default and activate now
vm-test-run-switch-test> machine # boot: make the configuration the boot default
vm-test-run-switch-test> machine # test: activate the configuration, but don't make it the boot default
vm-test-run-switch-test> machine # dry-activate: show what would be done if this configuration were activated
vm-test-run-switch-test> machine #
vm-test-run-switch-test> machine: output:
vm-test-run-switch-test> Test "pre-switch checks" failed with error: "command `/nix/store/69vika84p4i1qpgvnqaqrmnd2hqr38dh-stderr-runner /nix/store/9658x4bx9cn567a04776bg9qwsbw95qr-nixos-system-other-test/bin/switch-to-configuration check` failed (exit code 1)"
vm-test-run-switch-test> cleanup
vm-test-run-switch-test> kill machine (pid 9)
vm-test-run-switch-test> qemu-kvm: terminating on signal 15 from pid 6 (/nix/store/px2nj16i5gc3d4mnw5l1nclfdxhry61p-python3-3.12.7/bin/python3.12)
vm-test-run-switch-test> kill vlan (pid 7)
vm-test-run-switch-test> (finished: cleanup, in 0.01 seconds)
error: builder for '/nix/store/541460imnjxn66pvfx3jiqp1gd43k9l0-vm-test-run-switch-test.drv' failed with exit code 1
Add an option for shell script fragments that are ran before switching to a new NixOS system configuration (pre installation of bootloader or system activation). Also add a new subcommand for switch-to-configuration called "check" that will cause the program to always exit after checks are ran.
jmbaur
force-pushed
the
pre-switch-checks
branch
from
22dcf23 to
6e192c4
Compare
ConnorBaker
approved these changes
Nov 21, 2024
wegank
added
the
12.approvals: 2
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add an option for shell script fragments that are ran before switching to a new NixOS system configuration (pre installation of bootloader or system activation). Also add a new subcommand for
switch-to-configuration called "check" that will cause the program to always exit after checks are ran. If the
NO_CHECKenvironment variable is set to 1 during switch, the checks are skipped.Fixes #169820
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)