Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NixOS test for security.pam.enableSSHAgentAuth #266332

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Add NixOS test for security.pam.enableSSHAgentAuth #266332

merged 2 commits into from
Dec 31, 2023

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Nov 8, 2023 •
edited
Loading

Description of changes

Add a new NixOS test, for pam_ssh_agent_auth(8) support

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • Tested, as applicable:
    • nixosTests.ssh-agent-auth
    • made sure NixOS tests are linked to the relevant packages
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 8, 2023
@nbraud nbraud mentioned this pull request Nov 8, 2023
Merged
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 8, 2023
@nbraud nbraud force-pushed the nixos/tests/ssh-agent-auth branch from 166bf65 to 3105ad8 Compare December 24, 2023 15:16
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 24, 2023
@nbraud nbraud force-pushed the nixos/tests/ssh-agent-auth branch from 3105ad8 to fb464b9 Compare December 24, 2023 15:55
@nbraud nbraud added 6.topic: testing Tooling for automated testing of packages and modules 8.has: tests This PR has tests labels Dec 24, 2023
@nbraud nbraud force-pushed the nixos/tests/ssh-agent-auth branch from fb464b9 to 291120f Compare December 24, 2023 16:00
@nbraud nbraud force-pushed the nixos/tests/ssh-agent-auth branch from 291120f to 9b88127 Compare December 24, 2023 16:05
@github-actions github-actions bot removed 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 24, 2023
@nbraud nbraud marked this pull request as ready for review December 24, 2023 16:06
@nbraud nbraud mentioned this pull request Dec 24, 2023
Merged
5 tasks
@nbraud nbraud requested a review from Majiir December 29, 2023 11:12
@nbraud
Copy link
Contributor Author

nbraud commented Dec 29, 2023

@Majiir, I requested a review from you as the pam module's maintainer, but feel free to remove it if you don't have much to do with that specific PAM module.

Majiir
Majiir approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@Majiir Majiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nbraud nbraud added needs_merger (old Marvin label, do not use) 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 29, 2023
This was referenced Dec 29, 2023
Merged
Merged
@mkg20001 mkg20001 merged commit b8a8c2c into NixOS:master Dec 31, 2023
9 checks passed
@nbraud nbraud deleted the nixos/tests/ssh-agent-auth branch December 31, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Majiir Majiir Majiir approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 8.has: tests This PR has tests 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person needs_merger (old Marvin label, do not use)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nbraud @Majiir @mkg20001