emacsPackages: fix build for a few hundred packages #343925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails" This reverts commit 2421239. ignoreCompilationError defaults to false now.
It defaults to false now.
It defaults to false now.
It defaults to false now.
It defaults to false now.
- addPackageRequires - addPackageRequiresIfOlder - addPackageRequiresWhen - fixRequireHelmCore - ignoreCompilationError - ignoreCompilationErrorIfOlder - ignoreCompilationErrorWhen - mkHomeIfOlder - mkHomeWhen
…ationError at bytecompile time Previously, these two attributes were only respected at nativecompile time.
AndersonTorres
approved these changes
Sep 23, 2024
jian-lin
force-pushed
the
pr/fix-elisp-packages
branch
from
ce20c25 to
207d89c
Compare
| # missing optional dependencies | ||
| suggest = addPackageRequires super.suggest [ self.shut-up ]; | ||
|
|
||
| symex = ignoreCompilationError super.symex; # elisp error |
There was a problem hiding this comment.
I reported a bug to the symex maintainer, but it turns out that they couldn't replicate it. We managed to fix it anyhow.
I'm not saying that this particular commit is problematic, I just needed something symex-specific to link to. My theory is that the underlying error--which this ignores--was recently fixed. If I'm right about this, then the next time we update these packages this error might no longer show up. 🤞
There was a problem hiding this comment.
My theory is that the underlying error--which this ignores--was recently fixed.
I do not think so. Many errors reported in drym-org/symex.el#130 are in the build log. Those errors are not specific to nix and should be fixed upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fixes almost all build failures introduced by #343388.
The only remaining build failure is
org-xlatex, which fails for good reason:Error: error ("Your Emacs was not built with Xwidget support").It is better to review this PR one commit at a time.
Future work:
ignoreCompilationErrorThis PR is the final part of #335442. Closes #335442.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.