Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.ttfautohint-py: fix loading some modules #378514

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Feb 1, 2025

In #359496 there were some issues found when using ttfautohint-py this pr fix the missing dependencies.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378514


x86_64-linux

❌ 15 packages failed to build:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • smc-chilanka
  • smc-manjari
✅ 4 packages built:
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist

aarch64-linux

❌ 15 packages failed to build:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • smc-chilanka
  • smc-manjari
✅ 4 packages built:
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist

x86_64-darwin

❌ 15 packages failed to build:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • smc-chilanka
  • smc-manjari
✅ 4 packages built:
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist

aarch64-darwin

❌ 15 packages failed to build:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • smc-chilanka
  • smc-manjari
✅ 4 packages built:
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378514


x86_64-linux

✅ 19 packages built:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist
  • smc-chilanka
  • smc-manjari

aarch64-linux

✅ 19 packages built:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist
  • smc-chilanka
  • smc-manjari

x86_64-darwin

✅ 19 packages built:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist
  • smc-chilanka
  • smc-manjari

aarch64-darwin

✅ 19 packages built:
  • fira-math
  • python312Packages.fontmake
  • python312Packages.fontmake.dist
  • python312Packages.gftools
  • python312Packages.gftools.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python312Packages.ttfautohint-py
  • python312Packages.ttfautohint-py.dist
  • python313Packages.fontmake
  • python313Packages.fontmake.dist
  • python313Packages.gftools
  • python313Packages.gftools.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • python313Packages.ttfautohint-py
  • python313Packages.ttfautohint-py.dist
  • smc-chilanka
  • smc-manjari

@GaetanLepage GaetanLepage requested a review from NickCao February 1, 2025 23:24
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 2, 2025
@jopejoe1 jopejoe1 merged commit 6319929 into NixOS:master Feb 2, 2025
26 of 28 checks passed
@jopejoe1 jopejoe1 deleted the ttfautohint-py-fix-libc branch February 2, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants