Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: darkmode doesn't stay on refresh #218 #236

Merged
merged 4 commits into from
Feb 4, 2023

Conversation

Lourvens
Copy link
Contributor

Closes #

What new changes did you make? Tick all applicable boxes

  • Added new abbreviation
  • [v] Fixed something in the source code
  • Added a new feature
  • Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.

Share a screenshot of new changes

@vercel
Copy link

vercel bot commented Jan 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
abbreve ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 11:10PM (UTC)

@Lourvens
Copy link
Contributor Author

Closes #218

Describe the new changes you added.

Save the last theme on local storage and apply it to the webpage when loaded which automatically solves this issue.

Share a screenshot of new changes

chrome-capture-2023-0-31 (1)

Copy link
Owner

@Njong392 Njong392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing changes you've made! Thank you very much 🎉 Please take a look at the changes I have suggested.

src/components/navbar.jsx Outdated Show resolved Hide resolved
src/components/navbar.jsx Outdated Show resolved Hide resolved
src/components/navbar.jsx Outdated Show resolved Hide resolved
@Lourvens Lourvens requested a review from Njong392 January 31, 2023 23:02
@Lourvens
Copy link
Contributor Author

Lourvens commented Feb 2, 2023

@Njong392 I made the changes you suggested, Think it's time to review it thanks

Copy link
Owner

@Njong392 Njong392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now! Thank you so much for the stellar addition 🎉

@Njong392 Njong392 merged commit 62631a5 into Njong392:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants