Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename json_rpc_url to url in ForkConfig #745

Open
Wodann opened this issue Dec 11, 2024 · 2 comments
Open

Rename json_rpc_url to url in ForkConfig #745

Wodann opened this issue Dec 11, 2024 · 2 comments

Comments

@Wodann
Copy link
Member

Wodann commented Dec 11, 2024 •
edited
Loading

This work should be done in the feat/multichain branch.

Definition of Done

  • Rename json_rpc_url in the ForkConfig of edr_napi
  • Rename json_rpc_url in the ForkConfig of edr_provider
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Dec 11, 2024
@Wodann Wodann moved this from Unconfirmed to Todo in EDR Dec 11, 2024
@IftequarIffu
Copy link

Hey @Wodann, I would like to work on this issue. Please assign it to me.

@nebasuke
Copy link
Member

Hey @IftequarIffu, we generally don't pre-assign issues, to not stop other people from working on it later on. If you would like to work on this issue, please do, we'd welcome the contribution and we will review any PRs.

Thanks!

@iosh iosh mentioned this issue Dec 15, 2024
Closed
@IftequarIffu IftequarIffu mentioned this issue Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
EDR
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename json_rpc_url to url in ForkConfig of edr_napi and edr_provider. IftequarIffu/edr
4 participants
@fvictorio @nebasuke @Wodann @IftequarIffu