Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance regression in feat/multichain #761

Open
Wodann opened this issue Dec 31, 2024 · 0 comments
Open

Fix performance regression in feat/multichain #761

Wodann opened this issue Dec 31, 2024 · 0 comments

Comments

@Wodann
Copy link
Member

Wodann commented Dec 31, 2024

A performance regression of the synthetix benchmark was identified in #755 (GitHub CI).

I did some differential profiling between 6efbd64dd (old) and 682dbc5 (new) but wasn't able to identify the cause yet.

To construct the shown differential flamegraphs, I ran the following commands:

  1. PERF=/workspaces/WSL2-Linux-Kernel/tools/perf/perf CARGO_PROFILE_RELEASE_DEBUG=true cargo flamegraph -o flamegraph_synthetix_old.svg --root --release --post-process "tee synthetix-old.folded" -- scenario synthetix_9a3a109f.jsonl (for the old commit)
  2. PERF=/workspaces/WSL2-Linux-Kernel/tools/perf/perf CARGO_PROFILE_RELEASE_DEBUG=true cargo flamegraph -o flamegraph_synthetix_new.svg --root --release --post-process "tee synthetix-new.folded" -- scenario synthetix_9a3a109f.jsonl (for the new commit)
  3. inferno-diff-folded synthetix-old.folded synthetix-new.folded | inferno-flamegraph --negate > diff2.svg

This was inspired by this blogpost.

diff

diff2

@Wodann Wodann added this to EDR Dec 31, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Dec 31, 2024
@Wodann Wodann moved this from Unconfirmed to Todo in EDR Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant