-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmp.zip in root directory is not deleted #6
Comments
That sounds like two things that shouldn't happen. I'll fix it in a bit and see if I can add a way to test it better. Thanks for reporting it. |
Hi, the zip itself is being properly created (the module is working fine). However, I think the tmp.zip file should be created in a different folder then the where the repository is being exported (maybe export it in /tmp/tmp.zip) so it would not be in the resulting .zip file |
Might be that this PR fixes it: #7 |
Thanks for the PR but I won't merge it since i have a fancier implementation ready to go. I'm being held back by trying to do something fancy my windows setup isn't happy with, auto-generate a release version of the script on commit using husky. |
Thanks, my bad, I did not really use GitHub actions before and now see that you can run them on multiple OSes, so my PR wouldnt work on some of them. I tested 1.2 and the tmp.zip file is gone now. Thanks! |
Hi,
When using this module, there is a tmp.zip file in the zip file that can not be opened. Maybe the zip file can be deleted after the upload to S3?
The text was updated successfully, but these errors were encountered: