Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16.10: remove package source 1.0 service. remove obsolete APIs (in nuget.configuration that we added in 16.8) #10015

Closed
rrelyea opened this issue Sep 9, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#5334
Closed

16.10: remove package source 1.0 service. remove obsolete APIs (in nuget.configuration that we added in 16.8) #10015

rrelyea opened this issue Sep 9, 2020 · 1 comment · Fixed by NuGet/NuGet.Client#5334
Assignees
@zivkan
Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Oe Type:DCR Design Change Request
Milestone
6.8

Comments

@rrelyea
Copy link
Contributor

rrelyea commented Sep 9, 2020

Per @zivkan comment in PR: https://github.com/NuGet/NuGet.Client/pull/3649/files/e70389d28297073fc21d7d03a28c27143c66f290#r485233215

Consider approach for codespaces and these apis:
NuGet.Configuration.IPackageSourceProvider2
NuGet.Configuration.IPackageSourceProvider2.SavePackageSources(System.Collections.Generic.IEnumerable<NuGet.Configuration.PackageSource> sources, NuGet.Configuration.PackageSourceUpdateOptions packageSourceUpdateOptions) -> void
NuGet.Configuration.PackageSourceProvider.SavePackageSources(System.Collections.Generic.IEnumerable<NuGet.Configuration.PackageSource> sources, NuGet.Configuration.PackageSourceUpdateOptions sourceUpdateSettings) -> void
NuGet.Configuration.PackageSourceUpdateOptions
NuGet.Configuration.PackageSourceUpdateOptions.PackageSourceUpdateOptions(bool updateCredentials, bool updateEnabled) -> void
NuGet.Configuration.PackageSourceUpdateOptions.UpdateCredentials.get -> bool
NuGet.Configuration.PackageSourceUpdateOptions.UpdateEnabled.get -> bool
static readonly NuGet.Configuration.PackageSourceUpdateOptions.Default -> NuGet.Configuration.PackageSourceUpdateOptions
@rrelyea rrelyea added Product:VS.Oe Type:DCR Design Change Request labels Sep 9, 2020
@rrelyea rrelyea added this to the Sprint 176 - 2020.09.07 milestone Sep 9, 2020
@rrelyea rrelyea mentioned this issue Sep 9, 2020
Merged
@zkat zkat added the Priority:2 Issues for the current backlog. label Sep 17, 2020
@zkat zkat added Priority:1 High priority issues that must be resolved in the current sprint. and removed Priority:2 Issues for the current backlog. labels Sep 28, 2020
@rrelyea rrelyea self-assigned this Sep 30, 2020
@rrelyea rrelyea changed the title Consider removing these NuGet.Configuration public api before 5.8 ships Consider removing these NuGet.Configuration public api during 16.9 (and do good service versioning) Oct 1, 2020
@rrelyea rrelyea assigned sbanni and unassigned sbanni and rrelyea Oct 1, 2020
@rrelyea rrelyea removed this from the Sprint 178 - 2020.10.19 milestone Oct 19, 2020
@rrelyea rrelyea changed the title Consider removing these NuGet.Configuration public api during 16.9 (and do good service versioning) 16.10: remove package source 1.0 service. remove obsolete APIs (in nuget.configuration that we added in 16.8) Oct 19, 2020
@zivkan zivkan mentioned this issue Jan 12, 2021
Closed
@zivkan zivkan added the Functionality:SDK The NuGet client packages published to nuget.org label Jan 12, 2021
@zivkan
Copy link
Member

zivkan commented Jan 12, 2021

I saw and worked on #10098, before discovering this issue, and the other didn't specify a schedule.

Anyway, I've got a branch with the change, ready for a PR: https://github.com/NuGet/NuGet.Client/tree/dev-zivkan-remove-IPackageSourceProvider2

@zkat zkat added Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:1 High priority issues that must be resolved in the current sprint. labels Jul 12, 2021
@zivkan zivkan mentioned this issue Aug 2, 2023
Merged
8 tasks
@zivkan zivkan assigned zivkan and unassigned rrelyea Aug 2, 2023
@nkolev92 nkolev92 added this to the 6.8 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:VS.Oe Type:DCR Design Change Request
Projects
None yet
Milestone
6.8
Development

Successfully merging a pull request may close this issue.

Use Package Source name as key when updating nuget.config, to avoid duplicates NuGet/NuGet.Client
6 participants
@zkat @sbanni @nkolev92 @zivkan @rrelyea @heng-liu