Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet packages downloaded over 1 billion times show the wrong unit #10864

Closed
vsfeedback opened this issue May 13, 2021 · 8 comments · Fixed by NuGet/NuGet.Client#4255
Closed
Assignees
Labels
Functionality:VisualStudioUI Package Manager UI et al good first issue Issues identified as good for first-time contributors help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Tenet:Accessibility Type:Bug

Comments

@vsfeedback
Copy link

vsfeedback commented May 13, 2021

image

This issue has been moved from a ticket on Developer Community.


[severity:It bothers me. A fix would be nice]
I was just about to download Newtonsoft.Json and noticed that the NuGet package apparently has 1.02G downloads, isn't this supposed to be 1.02B?


Original Comments

Feedback Bot on 5/11/2021, 11:14 PM:

We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.


Original Solutions

(no solutions)

@erdembayar
Copy link
Contributor

@aortiz-msft @JonDouglas @jebriede
Do we need to make this change?

@JonDouglas
Copy link
Contributor

JonDouglas commented May 13, 2021

Can we tag it up for grabs or good first contribution & encourage someone to fix it? we're not in a huge rush and it's a great learning opportunity for someone's first contribution.

Also worthwhile to add the public code area and maybe a couple steps as to what someone might do to fix? :)

@erdembayar erdembayar added good first issue Issues identified as good for first-time contributors help wanted Considered good issues for community contributions. labels May 13, 2021
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Triage:NeedsTriageDiscussion Priority:2 Issues for the current backlog. labels May 20, 2021
@zivkan
Copy link
Member

zivkan commented Jun 17, 2021

I don't think we can accept a submission that simply changes the G to a B. The current code uses Standard International notation, and if we deviate from this, we probably need to localize to all of Visual Studio's supported languages.

Therefore, if we change it, we should introduce a new string resource for each suffix, handle the fact that not all languages will use single character abbreviations, and put a suitable comment in the string resource for translators to understand what each of these strings represent.

@aloisdg
Copy link

aloisdg commented Jun 17, 2021

As a European (and, caveat, the dude who brings the SI to Humanizer) please keep it as it. It is clearer for the non imperial world. Keep the k for thousands and the G for billion as per the standard :)

If we really want to translate it, let's add lakh, crore, arab, kharab, etc for our Indian friends.

But I really think that we should not deviate from the standard.

@Amritanshu02
Copy link

Hello! I would like to work on this issue , could you suggest me where to start??

@erdembayar
Copy link
Contributor

Please consider NuGet/NuGet.Client#4255 (comment) next time.

@erdembayar erdembayar added this to the Sprint 2021-09 milestone Sep 11, 2021
@erdembayar erdembayar self-assigned this Sep 11, 2021
@erdembayar
Copy link
Contributor

@aortiz-msft @chgill-MSFT @dominoFire @donnie-msft
As part of PR NuGet/NuGet.Client#4255 we 're getting this fix with localization. Now people in USA getting 1B, but people in other side of world still wants 1G. Do I need to request localization team to add translation or it happen automatically as part of workflow?

Previous experience on PMUI:
image

New experience on PMUI:
image

@dominoFire
Copy link
Contributor

@erdembayar Loc team will pick up loc changes automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:VisualStudioUI Package Manager UI et al good first issue Issues identified as good for first-time contributors help wanted Considered good issues for community contributions. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Tenet:Accessibility Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants