Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to see the background color of the number on the right of “Updates” and “Consolidate” tabs in the Dark theme #10896

Closed
v-luzh opened this issue May 27, 2021 · 8 comments · Fixed by NuGet/NuGet.Client#4269
Assignees
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:Accessibility Type:Bug

Comments

@v-luzh
Copy link

v-luzh commented May 27, 2021

Details about Problem

VS Version: Main\31326.288
NuGet Version: Release-6.0.x\6.0.0.66
OS Version: Windows-10-Enterprise-21H1

Repro steps and/or sample project

  1. Launch VS and create a solution with multiple projects.
  2. Open Tools->Options->Environment and select the “Dark” in the “Color Theme” drop-down list.
  3. Open the solution PM UI and install a package (with different versions) into difference projects.
  4. Check the background color of the number on the right of “Updates” and “Consolidate” tabs.

Expected

The background color of the number on the right of “Updates” and “Consolidate” tabs in the Dark theme is easy to see (like what we did in Blend theme in the Blend for VS as below).
image

Actual

Hard to see the background color of the number on the right of “Updates” and “Consolidate” tabs in the Dark theme as below screenshot.
image

Note

Seems it is caused by Dark theme design changed in VS so I didn't provide the NuGet regression info. But we should update the background color for the new design changes.

@aortiz-msft aortiz-msft added the Priority:1 High priority issues that must be resolved in the current sprint. label Jun 2, 2021
@aortiz-msft
Copy link
Contributor

@jebriede - Would you please take a look?

@v-luzh
Copy link
Author

v-luzh commented Jun 10, 2021

The bug doesn't repro on Main\31409.290 since the VS Dark theme design changed back as below.
image

@v-luzh
Copy link
Author

v-luzh commented Jun 15, 2021

Repro again on Main\31414.215.

@jebriede jebriede added the Category:Quality Week Issues that should be considered for quality week label Jun 28, 2021
@jebriede jebriede added this to the Sprint 2021-06 milestone Jun 28, 2021
@donnie-msft
Copy link
Contributor

@aortiz-msft just a reminder to always add product & type labels as well :)

@donnie-msft
Copy link
Contributor

donnie-msft commented Jul 7, 2021

I reached out to UX folks and they are actively working on styling, and are aware of this bug.

@aortiz-msft
Copy link
Contributor

@donnie-msft @jebriede - What are the next steps for this one?

@donnie-msft
Copy link
Contributor

@aortiz-msft I pinged UX team for an update.

@donnie-msft donnie-msft assigned donnie-msft and unassigned jebriede Aug 25, 2021
@donnie-msft donnie-msft added the Resolution:BlockedByExternal Progress on this task is blocked by an external issue. When that issue is completed this can proceed label Aug 25, 2021
@donnie-msft
Copy link
Contributor

Self-assigning since I've been talking to UX.
They are supposed to work on this bug this week: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1385968?src=WorkItemMention&src-action=artifact_link

@donnie-msft donnie-msft removed the Category:Quality Week Issues that should be considered for quality week label Sep 7, 2021
@donnie-msft donnie-msft removed the Resolution:BlockedByExternal Progress on this task is blocked by an external issue. When that issue is completed this can proceed label Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:Accessibility Type:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants