Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] The title, tooltip of the warning icon, description and details of vulnerable package have not been localized on PM UI #11194

Closed
v-longmin opened this issue Aug 30, 2021 · 5 comments
Assignees
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:WorldReady

Comments

@v-longmin
Copy link

v-longmin commented Aug 30, 2021

Details about problem

VS Version: D17.0\31616.261
OS Version: Windows-10-Enterprise-21H1

Installations

  1. Install VS D17.0\31616.261 from:
    https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5097037&view=ms.vss-build-web.run-extensions-tab

Steps to reproduce

  1. Create a new C# Console App (.Net Core) project and open PM UI.
  2. Search vulnerable package (refer to GitHub Advisory Database) in Browse tab.
  3. Select a vulnerable package (e.g. Microsoft.AspNetCore.Authentication.JwtBearer) and observe the information on the right panel.
  4. Install the vulnerable package and observe the tooltip of the warning icon in Installed tab.

Expected

The title, tooltip of the warning icon, description and details of vulnerable package should be localized.

Actual

The title, tooltip of the warning icon, description and details of vulnerable package have not been localized as below screenshot.
image
image

Notes

  1. The issue reproes on all languages.
  2. It is not a regression because it is a new feature.
@donnie-msft
Copy link
Contributor

After a chat with @dominoFire, he believes there may be a backlog for the localization team. Please follow-up here and reassign as necessary.

@aortiz-msft aortiz-msft added the Priority:1 High priority issues that must be resolved in the current sprint. label Sep 1, 2021
@dominoFire dominoFire added this to the Sprint 2021-09 milestone Sep 7, 2021
@dominoFire
Copy link
Contributor

Details pane appears localized:

image.png

Tooltip in PM UI tabs appears unlocalized

image.png

@dominoFire
Copy link
Contributor

Corresponding String resource Label_Installed_VulnerableAndDeprecatedWarning is localized:

https://github.com/NuGet/NuGet.Build.Localization/blob/e7189fde81534ca4dc50e96958db082ac313964c/localize/FRA/15/NuGet.PackageManagement.UI.dll.lcl#L1628

It was merged 4 days ago, at the time of this comment.

@dominoFire
Copy link
Contributor

A new version was inserted. @v-longmin would you please take another look? Thanks!

@dominoFire
Copy link
Contributor

lastes build shows the tooltip localized:
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:WorldReady
Projects
None yet
Development

No branches or pull requests

5 participants