Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] The tooltip of the deprecated package’s warning icon has not been localized on PM UI #11195

Closed
v-crchang opened this issue Aug 30, 2021 · 4 comments
Assignees
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:WorldReady

Comments

@v-crchang
Copy link

Details about problem:

VS Version: D17.0\31616.261
OS Version: Windows-10-Enterprise-20h2

Installation:

Install VS D17.0\31616.261 from:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5097037&view=ms.vss-build-web.run-extensions-tab

Repro steps:

  1. Create a C# Console App (.net core) project and open PM UI of the project.
  2. Select package source: Nuget.org
  3. Search deprecated package "NuGet.Core" in Browse tab.
  4. Hover on the warning icon of the deprecated package “NuGet.Core” and observe the tooltip.

Expected:

The tooltip of the warning icon should be localized.

Actual:

The tooltip of the warning icon has not been localized as below screenshot.
image

Notes:

  1. The issue reproes on all languages.
  2. It starts to repro from the new feature “Deprecated Package” merged.
@donnie-msft
Copy link
Contributor

After a chat with @dominoFire, he believes there may be a backlog for the localization team. Please follow-up here and reassign as necessary.

@aortiz-msft aortiz-msft added the Priority:1 High priority issues that must be resolved in the current sprint. label Sep 1, 2021
@dominoFire dominoFire added this to the Sprint 2021-09 milestone Sep 7, 2021
@dominoFire
Copy link
Contributor

dominoFire commented Sep 7, 2021

It appears localized in spanish in Recent VS build:

image.png

image.png

@dominoFire
Copy link
Contributor

This commit contains all localized strings for tooltip:

NuGet/NuGet.Build.Localization@f904c2c#diff-2a68c6ea49bcdf3c33c527be451b06e7efa6e5ce2904bcc3d6d3855a8d3b4e08

@dominoFire
Copy link
Contributor

dominoFire commented Sep 7, 2021

Localized string resource is Label_PackageSelectForInfoToolTip: https://github.com/NuGet/NuGet.Build.Localization/blob/e7189fde81534ca4dc50e96958db082ac313964c/localize/FRA/15/NuGet.PackageManagement.UI.dll.lcl#L1720

I will close the issue since all localized strings are present in all 13 languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Found:ManualTests Functionality:VisualStudioUI Package Manager UI et al Priority:1 High priority issues that must be resolved in the current sprint. Product:VS.Client Tenet:WorldReady
Projects
None yet
Development

No branches or pull requests

5 participants