Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Locator: Use GetServiceAsync extensions instead of custom ones, move certain sync calls to async, remove certain GetInstance calls, avoid fetching the IComponentModel service so frequently #4236

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Service Locator: Use GetServiceAsync extensions instead of custom ones, move certain sync calls to async, remove certain GetInstance calls, avoid fetching the IComponentModel service so frequently #4236

merged 2 commits into from
Sep 29, 2021

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Sep 1, 2021 •
edited
Loading

Bug

Fixes: NuGet/Home#11200

Regression? Last working version:

Description

  • Use GetServiceAsync extensions instead of custom ones
  • move certain sync calls to async - remove GetInstanceSafe method.
  • remove certain GetInstance calls
  • avoid fetching the IComponentModel service so frequently

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 requested a review from a team as a code owner September 1, 2021 19:41
@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 8, 2021
@ghost
Copy link

ghost commented Sep 8, 2021

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 10, 2021
@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 18, 2021
@ghost
Copy link

ghost commented Sep 18, 2021

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@nkolev92
Copy link
Member Author

Hey @aortiz-msft

Hoping I can get an approval for this.

These changes are part of the initialization UI delays, reducing the UI thread requests.
The previous insertion had an issue which has been addressed in this PR.

@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 20, 2021
@ghost ghost added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 27, 2021
@ghost
Copy link

ghost commented Sep 27, 2021

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@nkolev92
Copy link
Member Author

Ready to be merged, rejected for 6.0, waiting for dev to be 6.1 to merge.

@ghost ghost removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 27, 2021
@nkolev92 nkolev92 merged commit 60b3df4 into dev Sep 29, 2021
@nkolev92 nkolev92 deleted the dev-nkolev92-moreServiceLocatorCleanup branch September 29, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkan zivkan zivkan approved these changes

@kartheekp-ms kartheekp-ms kartheekp-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nkolev92 @zivkan @kartheekp-ms