Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all sync ServiceLocator calls and move to async where possible #11203

Closed
Tracked by #11198
nkolev92 opened this issue Aug 30, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4716
Closed
Tracked by #11198

Review all sync ServiceLocator calls and move to async where possible #11203

nkolev92 opened this issue Aug 30, 2021 · 0 comments · Fixed by NuGet/NuGet.Client#4716
Assignees
@nkolev92
Labels
Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug
Milestone
6.4

Comments

@nkolev92
Copy link
Member

Note that this may lead some larger tasks.

Use common sense. Fix the easy ones, create an issue for ones that can feasibly move to async codepaths.

Note that a lot of the PMC ones cannot be made async, simple by virtue of PMC being mostly sync.
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug labels Aug 30, 2021
@nkolev92 nkolev92 mentioned this issue Aug 30, 2021
Merged
8 tasks
@nkolev92 nkolev92 modified the milestone: Sprint 2022-03 Mar 7, 2022
@nkolev92 nkolev92 mentioned this issue Apr 27, 2022
Closed
2 tasks
@nkolev92 nkolev92 self-assigned this Jul 7, 2022
@nkolev92 nkolev92 mentioned this issue Jul 7, 2022
Merged
8 tasks
@kartheekp-ms kartheekp-ms added this to the 6.4 milestone Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Priority:2 Issues for the current backlog. Product:VS.Client Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
6.4
Development

Successfully merging a pull request may close this issue.

Cleanup ServiceLocator usages - Retrieve the services in a more specific fashion. NuGet/NuGet.Client
3 participants
@nkolev92 @heng-liu @kartheekp-ms