Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCR]: Rename packageNamespaces feature to packageSourceMapping #11205

Closed
kartheekp-ms opened this issue Aug 31, 2021 · 1 comment · Fixed by NuGet/NuGet.Client#4234
Closed
Assignees
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Area:Settings NuGet.Config and related issues Type:DCR Design Change Request

Comments

@kartheekp-ms
Copy link
Contributor

kartheekp-ms commented Aug 31, 2021

NuGet Product(s) Affected

NuGet.exe, Visual Studio Package Management UI, Visual Studio Package Manager Console, MSBuild.exe, dotnet.exe

Current Behavior

Namespaces configuration currently can be configured as follows

<packageNamespaces>
    <packageSource key="nuget.org">
      <namespace id="*" />
    </packageSource>
    <packageSource key="contoso.com">
      <namespace id="Contoso.*" />
    </packageSource>
</packageNamespaces>

Desired Behavior

Namespaces configuration should be as follows.

  1. Rename packageNamespaces to packageSourceMapping
  2. Rename namespace to package
  3. Rename id to pattern
<packageSourceMapping>
    <packageSource key="nuget.org">
      <package pattern="*" />
    </packageSource>
    <packageSource key="contoso.com">
      <package pattern="Contoso.*" />
    </packageSource>
</packageSourceMapping>

Additional Context

No response

@kartheekp-ms kartheekp-ms added Type:DCR Design Change Request Area:Settings NuGet.Config and related issues Area:PackageSourceMapping Issues related to the package source mapping feature labels Aug 31, 2021
@kartheekp-ms kartheekp-ms added this to the Sprint 2021-08 milestone Aug 31, 2021
@kartheekp-ms kartheekp-ms self-assigned this Aug 31, 2021
@loic-sharma
Copy link
Contributor

Just curious, why did we decide to rename these? Personally I slightly preferred the old names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Area:Settings NuGet.Config and related issues Type:DCR Design Change Request
Projects
None yet
2 participants