[Bug]: VS crashes when package sources dropdown in PM UI has multiple package sources whose names are equal when compared using Culture Ignore Case

[kartheekp-ms]

NuGet Product Used

Visual Studio Package Management UI

Product Version

VS 2022 and didn't test previous versions.

Worked before?

No response

Impact

Other

Repro Steps & Context

1. Create a ClassLibrary project in Visual Studio
2. Close the solution after it is created
3. Add a nuget.config file with below content under solution folder.

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <config>
    <add key="globalPackagesFolder" value="globalPackagesFolder" />
  </config>
  <packageSources>
    <clear />
    <add key="encyclopaedia" value="https://api.nuget.org/v3/index.json" />
    <add key="encyclopædia" value="https://pkgs.dev.azure.com/azure-public/vside/_packaging/vssdk/nuget/v3/index.json" />
  </packageSources>  
</configuration>

Note - The package source names are different when compared using ordinal ignore case and they are equal when compared using culture ignore case option.

Reference - https://docs.microsoft.com/en-us/dotnet/api/system.stringcomparison?view=net-5.0#examples

//       encyclopædia = encyclopaedia (CurrentCultureIgnoreCase): 
//       encyclopædia != encyclopaedia (OrdinalIgnoreCase): 

4. open the solution in VS
5. Navigate to browse tab in PM UI
6. Change package source option to All

Actual behavior:
VS crashes

Expected behavior:
VS opens packages in the browse tab successfully

ClassLibrary38.zip

Verbose Logs

No response

[kartheekp-ms]

The exception message is

System.ArgumentException
HResult=0x80070057
Message=Item has already been added. Key in dictionary: 'encyclopaedia' Key being added: 'encyclopædia'
Source=mscorlib
StackTrace:
at System.Collections.SortedList.Add(Object key, Object value)
at NuGet.PackageManagement.UI.LoadingStatusViewModel.UpdateModel(IItemLoaderState loaderState)
at NuGet.PackageManagement.UI.InfiniteScrollList.<>c__DisplayClass51_0.<b__0>d.MoveNext()
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()
at NuGet.PackageManagement.UI.InfiniteScrollList.HandleItemLoaderStateChange(IItemLoader1 loader, IItemLoaderState state) at System.Progress1.InvokeHandlers(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch()

This exception was originally thrown at this call stack:
[External Code]

[kartheekp-ms]

The fix for this issue seems to be an easy one.

Change
https://github.com/NuGet/NuGet.Client/blob/1af032a9a12c530ef434e9ea1a53cd93348e1146/src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/LoadingStatusViewModel.cs#L25
to

var convertedList = new System.Collections.SortedList(StringComparer.OrdinalIgnoreCase);

This fix may be relevant given that we are fixing string comparision issues NuGet/NuGet.Client#4264
//cc @erdembayar