Run netfx tests with 64-bit xunit #4271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Sep 17, 2021
aortiz-msft
approved these changes
Sep 17, 2021
donnie-msft
approved these changes
Sep 17, 2021
kartheekp-ms
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
The xunit.runner.console package has a .props file with below properties defined. Can we just use XunitConsole472Path property instead in a follow-up PR?
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
//removed to keep the content simple
<XunitConsole472Path>$(MSBuildThisFileDirectory)..\tools\net472\xunit.console.exe</XunitConsole472Path>
<XunitConsole472PathX86>$(MSBuildThisFileDirectory)..\tools\net472\xunit.console.x86.exe</XunitConsole472PathX86>
</PropertyGroup>
</Project>
|
We could, I like the idea. I was going to commit the change now, but we'd still need to import the props file, so when the package version changes, there will still be two places to modify (PackageDownload, and the import path), so in the end it doesn't make it any "easier" to change package versions. So, I'm going to merge as-is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11243
Regression? Last working version:
Description
Run .NET Framework tests with 64-bit
xunit.console.exe, rather than 32-bitxunit.console.x86.exe.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation